Attachment 168222 Details for Bug 37038 – Bug 37038: (QA follow-up) Replace \> by -gt

[patch] Bug 37038: (QA follow-up) Replace \> by -gt

Bug-37038-QA-follow-up-Replace--by--gt.patch (text/plain), 1.31 KB, created by Marcel de Rooy on 2024-06-28 06:45:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-06-28 06:45:04 UTC

Size: 1.31 KB

patch

obsolete

>From 62d53f67dbbdce164ce4f31f29e05d8e28f0f41f Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 28 Jun 2024 06:29:50 +0000
>Subject: [PATCH] Bug 37038: (QA follow-up) Replace \> by -gt
>Content-Type: text/plain; charset=utf-8
>
>Note that -gt is the bash integer comparison and > is the
>lexical one:
>$ if [ '1' \> '09' ]; then echo true; fi
>true
>$ if [ '1' -gt '09' ]; then echo true; fi
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>[EDIT] Added the dev/null redirection to suppress warn in bin/sh.
>---
> debian/scripts/koha-elasticsearch | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/debian/scripts/koha-elasticsearch b/debian/scripts/koha-elasticsearch
>index 24f4970941..f337b8fa71 100755
>--- a/debian/scripts/koha-elasticsearch
>+++ b/debian/scripts/koha-elasticsearch
>@@ -90,12 +90,12 @@ run_rebuild_elasticsearch()
>         KOHA_BINDIR=${KOHA_HOME}/misc
>     fi
> 
>-    if [ "${clo_commit_size}" \> 0 ]; then
>+    if [ "${clo_commit_size}" -gt 0 ] 2>/dev/null; then
>         commit_size=${clo_commit_size}
>     fi
>     rebuild_opts="--commit ${commit_size}"
> 
>-    if [ "${clo_processes}" \> 0 ]; then
>+    if [ "${clo_processes}" -gt 0 ] 2>/dev/null; then
>         processes=${clo_processes}
>     fi
>     rebuild_opts="${rebuild_opts} --processes ${processes}"
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37038: 167487 | 167491 | 168220 | 168221 | 168222