Attachment 168225 Details for Bug 32575 – Bug 32575: Add an empty text body to fix multipart/mixed handling

[patch] Bug 32575: Add an empty text body to fix multipart/mixed handling

Bug-32575-Add-an-empty-text-body-to-fix-multipartm.patch (text/plain), 1.63 KB, created by Marcel de Rooy on 2024-06-28 07:33:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-06-28 07:33:33 UTC

Size: 1.63 KB

patch

obsolete

>From 575b0fdd68d1a170535295f2075ed6ed8f1a7153 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 17 Jun 2024 02:23:36 +0000
>Subject: [PATCH] Bug 32575: Add an empty text body to fix multipart/mixed
> handling
>Content-Type: text/plain; charset=utf-8
>
>By adding an empty text body, we force Email::Stuffer/Email::MIME
>to use multipart/mixed handling for the attachment instead of forcing
>a single part (ie direct attachment) email, which is not consistently
>handled by different email clients.
>
>An empty text body is language-neutral (ie not imposing English),
>and it allows SMTP servers to inject organisational footers into
>the email (e.g. confidentiality notices).
>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>I have tested this solution in production, and it works for me.
>
>Bug 32575: Tidy patch
>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> misc/cronjobs/gather_print_notices.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/misc/cronjobs/gather_print_notices.pl b/misc/cronjobs/gather_print_notices.pl
>index f3d32cb6b8..8cd325e904 100755
>--- a/misc/cronjobs/gather_print_notices.pl
>+++ b/misc/cronjobs/gather_print_notices.pl
>@@ -291,9 +291,10 @@ sub send_files {
> 
>     my $email = Koha::Email->create(
>         {
>-            from    => $from,
>-            to      => $to,
>-            subject => 'Print notices for ' . $today_syspref,
>+            from      => $from,
>+            to        => $to,
>+            subject   => 'Print notices for ' . $today_syspref,
>+            text_body => ' ',
>         }
>     );
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32575: 167779 | 167780 | 167781 | 167820 | 167821 | 168225