Attachment 16825 Details for Bug 9909 – Bug 9909: Don't install KitchenSink plugin if plugin dir isn't writable

[patch] Bug 9909: Don't install KitchenSink plugin if plugin dir isn't writable

Bug-9909-Dont-install-KitchenSink-plugin-if-plugin.patch (text/plain), 1.28 KB, created by Jared Camins-Esakov on 2013-03-23 01:52:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jared Camins-Esakov

Created: 2013-03-23 01:52:08 UTC

Size: 1.28 KB

patch

obsolete

>From 1a213cb3349a9b483e8a77106bf17a5042ecd574 Mon Sep 17 00:00:00 2001
>From: Jared Camins-Esakov <jcamins@cpbibliography.com>
>Date: Fri, 22 Mar 2013 21:49:27 -0400
>Subject: [PATCH] Bug 9909: Don't install KitchenSink plugin if plugin dir
> isn't writable
>
>---
> t/db_dependent/Plugins.t |    6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Plugins.t b/t/db_dependent/Plugins.t
>index 1b87d2a..bb7a836 100755
>--- a/t/db_dependent/Plugins.t
>+++ b/t/db_dependent/Plugins.t
>@@ -45,9 +45,11 @@ my @plugins = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins( 'report'
> ok( $plugins[0]->get_metadata()->{'name'} eq 'Test Plugin', "Koha::Plugins::GetPlugins functions correctly" );
> 
> SKIP: {
>-    skip "plugindir not set", 3 unless C4::Context->config("pluginsdir");
>-
>     my $plugins_dir = C4::Context->config("pluginsdir");
>+    skip "plugindir not set", 3 unless defined $plugins_dir;
>+    skip "plugindir not writable", 3 unless -w $plugins_dir;
>+    skip "KitchenSink plugin already installed", 3 if (-f "$plugins_dir/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm");
>+
>     my $ae = Archive::Extract->new( archive => "$Bin/KitchenSinkPlugin.kpz", type => 'zip' );
>     unless ( $ae->extract( to => $plugins_dir ) ) {
>         warn "ERROR: " . $ae->error;
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9909: 16825