Attachment 168297 Details for Bug 37108 – Bug 37108 - cash register statistics wizard is wrongly sorting payment by manager_id branchcode

[patch] Bug 37108 - cash register statistics wizard is wrongly sorting payment by manager_id branchcode

Bug-37108---cash-register-statistics-wizard-is-wro.patch (text/plain), 2.54 KB, created by Alexandre Noel on 2024-06-28 20:20:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alexandre Noel

Created: 2024-06-28 20:20:39 UTC

Size: 2.54 KB

patch

obsolete

>From a1c95cbc0267c0886132814a8d73e1a1ce1d5905 Mon Sep 17 00:00:00 2001
>From: Alexandre Noel <alexandre.noel@inlibro.com>
>Date: Fri, 28 Jun 2024 16:16:19 -0400
>Subject: [PATCH] Bug 37108 - cash register statistics wizard is wrongly
> sorting payment by manager_id branchcode
>
>With this patch, it displays now the accountlines branchcode and not the
>manager's branchcode.
>
>(cr: Marie-Luce test plan)
>
>Setup - before test
>
>Staff accounts
>    - have a superlibrarian account
>    - create 2 limited access staff accounts, one by branches:
>        e.g.
>        - staff 1 - attached to branch A
>        - staff 2 - attached to branch B
>
>    Both restricted staff accounts should have the following permissions:
>
>        - (circulate) ,
>        - (borrowers),
>        - in the patron fines: (manual_invoice), and (remaining_permissions)
>        - ***ability to switch login library (loggedinlibrary)
>
>Debit type
>    - Add few debit types in your Koha (administration > debit types) to ease transactions search.
>        e.g: "printing cost", "new card", "lost item"
>
>        ***Ensure that each debit type is configured to "can be manually invoiced"
>
>Test plan
>
>1.  Login with "staff 1" in the intranet
>    --> Koha should connect to branch A
>2.  Find a "branch A" patron
>3.  Add a manual invoice    (e.g printing -- 2.50$ )
>4.  Pay this invoice
>5.  Log out of the intranet
>6.  Login with "staff2"
>    --> Koha should connect to branch B
>7.  Find a "branch B" patron
>8.  Add a manual invoice with a unique debit type and amount (e.g. lost item - 12.80$ )
>9.  Pay this invoice
>10. Stay connect with "staff2" account, and switch to "branch A" at the top right corner of the screen
>11. Find another "branch A" patron
>12. Add a manual invoice with a unique debit type and amount (e.g. new card - 5.00$ )
>13. Pay this invoice
>14. Log out
>15. Login with a "superlibrarian" account
>16. Run the "Cash register" statistics wizards for "branch A"
>        - Go to (Reports > Statistics wizards > Cash Registers )
>        - dates: select the current date
>---
> reports/cash_register_stats.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/reports/cash_register_stats.pl b/reports/cash_register_stats.pl
>index 1dde63b114..f0e3161ac3 100755
>--- a/reports/cash_register_stats.pl
>+++ b/reports/cash_register_stats.pl
>@@ -88,7 +88,7 @@ if ($do_it) {
> 
>     my $whereBranchCode = q{};
>     if ($manager_branchcode ne 'ALL') {
>-        $whereBranchCode = q{ AND m.branchcode = ?};
>+        $whereBranchCode = q{ AND al.branchcode = ?};
>         push @extra_params, $manager_branchcode;
>     }
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37108: 168297 | 168516