Attachment 168307 Details for Bug 37183 – Bug 37183: Batch edit serial subscriptions sets expiration date to today

[patch] Bug 37183: Batch edit serial subscriptions sets expiration date to today

Bug-37183-Batch-edit-serial-subscriptions-sets-exp.patch (text/plain), 2.30 KB, created by Martin Renvoize (ashimema) on 2024-07-01 08:26:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-07-01 08:26:50 UTC

Size: 2.30 KB

patch

obsolete

>From a4b7ba92201dcc7dbc5f64cc5bed272670792a02 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chris@bigballofwax.co.nz>
>Date: Sat, 29 Jun 2024 22:52:42 +0000
>Subject: [PATCH] Bug 37183: Batch edit serial subscriptions sets expiration
> date to today
>
>Test plan:
>
>Add some serials:
>1) Add a new serial, visit:
>   /cgi-bin/koha/serials/subscription-add.pl
>2) Put a biblionumber in the 'record' field, e.g. '112'.
>   Press 'next' and click 'ok' on the alert box.
>3) Fill all the required fields and click 'test prediction'.
>4) Fill the Subscription end date (= Expiration Date).
>5) Click 'save subscription'.
>6) Repeat steps 1-5 to create a second serial.
>
>Batch edit serials:
>1) Visit serials and hit the 'Search' button:
>   /cgi-bin/koha/serials/serials-home.pl
>2) Click the 2 checkboxes for the 2 serials we created
>   previously and click the new link that pops up
>   'Edit selected serials'.
>3) Click 'Save' without changing anything.
>4) Go back to either of the serials, notice the value
>   for Expiration date is changed to TODAY
>   (the date of the batch edit).
>
>Apply the patch and retest the batch editing (before
>retesting, change the expiration dates of the two
>serials back to the original expiration date).
>
>Note that the expiration date now only changes if you
>enter a date in the 'Expiration date' field.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> serials/subscription-batchedit.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/serials/subscription-batchedit.pl b/serials/subscription-batchedit.pl
>index 903db1c4f0a..cb2f65c0985 100755
>--- a/serials/subscription-batchedit.pl
>+++ b/serials/subscription-batchedit.pl
>@@ -61,8 +61,9 @@ if ( $op eq 'cud-batchedit' ) {
>         notes           => scalar $cgi->param('notes'),
>         internalnotes   => scalar $cgi->param('internalnotes'),
>         serialsadditems => scalar $cgi->param('serialsadditems'),
>-        enddate         => dt_from_string( scalar $cgi->param('enddate') ),
>     );
>+    # If we convert a blank string we get todays date, we should only convert enddate if it is not blank
>+    $params{'enddate'} = dt_from_string( scalar $cgi->param('enddate') ) if $cgi->param('enddate');
> 
>     my $field_values = {};
>     foreach my $field (@available_additional_fields) {
>-- 
>2.45.2

Actions: View | Diff | Splinter Review

Attachments on bug 37183: 168299 | 168305 | 168307