Bugzilla – Attachment 168364 Details for
Bug 37055
WaitingNotifyAtCheckout should only trigger on patrons with waiting holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37055: Check count of holds, not if defined
Bug-37055-Check-count-of-holds-not-if-defined.patch (text/plain), 1.94 KB, created by
Matt Blenkinsop
on 2024-07-02 13:03:41 UTC
(
hide
)
Description:
Bug 37055: Check count of holds, not if defined
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2024-07-02 13:03:41 UTC
Size:
1.94 KB
patch
obsolete
>From 17ac474f581587acee1d0bce168f17b2477923c6 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 14 Jun 2024 18:02:02 +0000 >Subject: [PATCH] Bug 37055: Check count of holds, not if defined > >To test: > - enable WaitingNotifyAtCheckout > - have or create a waiting hold for a patron > - check out an item to a different patron who does not have a waiting hold > - Koha says "This patron has waiting holds that are available for checkout" > - Apply patch > - Reload patron (click 'Checkout' tab) > - Check out an item - no warning > - Find the patron with waiting hold > - Check out an item - warning > - Checkout the waiting item - no warning > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> >Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index ff812fe5c1..d61b0df64b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -965,7 +965,7 @@ > </div> <!-- /.modal-dialog --> > </div> <!-- /#barcodeSubmittedModal --> > >-[% IF waiting_holds %] >+[% IF waiting_holds.count > 0 %] > <div id="circ-warnwaitingholds-modal" class="modal fade audio-alert-action block"> > <div class="modal-dialog"> > <div class="modal-content"> >@@ -1064,7 +1064,7 @@ > var newin = window.open(link, 'popup', 'width=600,height=400,resizable=1,toolbar=0,scrollbars=1,top'); > } > $(document).ready(function() { >- [% IF waiting_holds %] >+ [% IF waiting_holds.count > 0 %] > $('#circ-warnwaitingholds-modal .btn-primary').on('click',function() { > $('#mainform').submit(); > }); >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37055
:
167758
|
167980
| 168364