Attachment 168402 Details for Bug 37233 – Bug 37233: Library URL broken on in libraries tables

[patch] Bug 37233: Library URL broken on in libraries tables

Bug-37233-Library-URL-broken-on-in-libraries-table.patch (text/plain), 2.03 KB, created by David Nind on 2024-07-02 18:57:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-07-02 18:57:50 UTC

Size: 2.03 KB

patch

obsolete

>From 80f7287391726ebe1012657d707082274946e5ac Mon Sep 17 00:00:00 2001
>From: Janusz Kaczmarek <januszop@gmail.com>
>Date: Tue, 2 Jul 2024 15:24:21 +0000
>Subject: [PATCH] Bug 37233: Library URL broken on in libraries tables
>
>The URL given for a library is badly encoded in the table on the
>/cgi-bin/koha/admin/branches.pl page.  As a result, clicking on the link
>leads to 404 page.
>
>Test plan:
>==========
>1. Have a library with a URL defined.
>2. In the table on the Libraries page (/cgi-bin/koha/admin/branches.pl)
>   click the link with the URL.
>   You should get "Error 404".
>3. Apply the patch; restart_all.
>4. Go to the Libraries page.  Ctrl+R to reload JS.
>   You should be able to reach the URL given in the library setup now.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index 37afcd259b..d4bd388f27 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -707,7 +707,7 @@
>                             if ( row.phone != null ) library_info.push(_("Ph: ") + row.phone.escapeHtml());
>                             if ( row.fax != null ) library_info.push(_("Fax: ") + row.fax.escapeHtml());
>                             if ( row.email != null ) library_info.push('<a href="mailto:'+encodeURIComponent(row.email)+'">'+row.email.escapeHtml()+'</a>');
>-                            if ( row.url != null ) library_info.push('<a href="'+encodeURIComponent(row.url)+'">'+row.url.escapeHtml()+'</a>');
>+                            if ( row.url != null ) library_info.push('<a href="'+encodeURI(row.url)+'">'+row.url.escapeHtml()+'</a>');
>                             if ( row.notes != null ) library_info.push(_("Notes")+': '+row.notes.escapeHtml());
>                             return library_info.join('<br/>');
>                         },
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37233: 168380 | 168402