Bugzilla – Attachment 168419 Details for
Bug 37065
Bookings tab should filter out expired bookings by default
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37065: (follow-up) Terminology and active mixup
Bug-37065-follow-up-Terminology-and-active-mixup.patch (text/plain), 2.64 KB, created by
Martin Renvoize (ashimema)
on 2024-07-03 06:02:29 UTC
(
hide
)
Description:
Bug 37065: (follow-up) Terminology and active mixup
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-07-03 06:02:29 UTC
Size:
2.64 KB
patch
obsolete
>From 3771e484f9cd1d8135ec10111561f8d229cf39c0 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 3 Jul 2024 07:01:08 +0100 >Subject: [PATCH] Bug 37065: (follow-up) Terminology and active mixup > >--- > .../prog/en/modules/bookings/list.tt | 20 +++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >index 2fa1cd694ad..619397a1f63 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >@@ -44,7 +44,7 @@ > <div class="page-section" id="bookings-timeline"></div> > <div class="page-section"> > <fieldset class="action filters" style="cursor:pointer;"> >- <a id="completed_filter" class="filtered"><i class="fa fa-bars"></i> Include completed</a> >+ <a id="expired_filter" class="filtered"><i class="fa fa-bars"></i> Show expired</a> > </fieldset> > > <table id="bookings_table"></table> >@@ -202,10 +202,10 @@ > } > ); > >- let filter_completed = true; >+ let filter_expired = true; > let additional_filters = { > end_date: function(){ >- if ( filter_completed ) { >+ if ( filter_expired ) { > let today = new Date(); > return { ">=": today.toISOString() } > } else { >@@ -299,15 +299,15 @@ > }] > }, [], 0, additional_filters); > >- var txtActivefilter = _("Include completed"); >- var txtInactivefilter = _("Filter completed"); >- $('#completed_filter').on("click", function() { >+ var txtActivefilter = _("Show expired"); >+ var txtInactivefilter = _("Hide expired"); >+ $("#expired_filter").on("click", function() { > if ($(this).hasClass('filtered')){ >- filter_completed = false; >- $(this).html('<i class="fa fa-filter"></i> '+txtActivefilter); >+ filter_expired = false; >+ $(this).html('<i class="fa fa-filter"></i> '+txtInactivefilter); > } else { >- filter_completed = true; >- $(this).html('<i class="fa fa-bars"></i> '+txtInactivefilter); >+ filter_expired = true; >+ $(this).html('<i class="fa fa-bars"></i> '+txtActivefilter); > } > bookings_table.DataTable().draw(); > $(this).toggleClass('filtered'); >-- >2.45.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37065
:
167932
|
168185
|
168419
|
168421