Bugzilla – Attachment 168421 Details for
Bug 37065
Bookings tab should filter out expired bookings by default
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37065: Filter expired bookings by default
Bug-37065-Filter-expired-bookings-by-default.patch (text/plain), 2.79 KB, created by
Julian Maurice
on 2024-07-03 06:45:53 UTC
(
hide
)
Description:
Bug 37065: Filter expired bookings by default
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2024-07-03 06:45:53 UTC
Size:
2.79 KB
patch
obsolete
>From 48d59f9cf67cc46551524d46ef6c1778fc3a923f Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 20 Jun 2024 11:41:15 +0100 >Subject: [PATCH] Bug 37065: Filter expired bookings by default > >This patch adds a default filter for the bookings table on the bookings >tab of a biblio. We also add the option to turn off the filtering after >initial page load. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > .../prog/en/modules/bookings/list.tt | 33 ++++++++++++++++++- > 1 file changed, 32 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >index f1c299a40c..619397a1f6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >@@ -43,6 +43,10 @@ > <h1>Bookings for [% INCLUDE 'biblio-title-head.inc' %]</h1> > <div class="page-section" id="bookings-timeline"></div> > <div class="page-section"> >+ <fieldset class="action filters" style="cursor:pointer;"> >+ <a id="expired_filter" class="filtered"><i class="fa fa-bars"></i> Show expired</a> >+ </fieldset> >+ > <table id="bookings_table"></table> > </div> > </div> >@@ -198,6 +202,18 @@ > } > ); > >+ let filter_expired = true; >+ let additional_filters = { >+ end_date: function(){ >+ if ( filter_expired ) { >+ let today = new Date(); >+ return { ">=": today.toISOString() } >+ } else { >+ return; >+ } >+ } >+ }; >+ > var bookings_table_url = "/api/v1/biblios/[% biblionumber | uri %]/bookings"; > bookings_table = $('#bookings_table').kohaTable({ > "ajax": { >@@ -281,7 +297,22 @@ > return result; > } > }] >- }, [], 0); >+ }, [], 0, additional_filters); >+ >+ var txtActivefilter = _("Show expired"); >+ var txtInactivefilter = _("Hide expired"); >+ $("#expired_filter").on("click", function() { >+ if ($(this).hasClass('filtered')){ >+ filter_expired = false; >+ $(this).html('<i class="fa fa-filter"></i> '+txtInactivefilter); >+ } else { >+ filter_expired = true; >+ $(this).html('<i class="fa fa-bars"></i> '+txtActivefilter); >+ } >+ bookings_table.DataTable().draw(); >+ $(this).toggleClass('filtered'); >+ }); >+ > }); > </script> > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37065
:
167932
|
168185
|
168419
| 168421