Bugzilla – Attachment 168490 Details for
Bug 18317
Allow check out of already checked out items through SIP
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18317: Perl tidy
Bug-18317-Perl-tidy.patch (text/plain), 2.55 KB, created by
Martin Renvoize
on 2024-07-04 08:42:04 UTC
(
hide
)
Description:
Bug 18317: Perl tidy
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2024-07-04 08:42:04 UTC
Size:
2.55 KB
patch
obsolete
>From b17772213a09ea6c1474d6c30e6ccd1b099f1e39 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 9 Nov 2023 01:57:33 +0000 >Subject: [PATCH] Bug 18317: Perl tidy > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/SIP/ILS.pm | 10 ++++++---- > C4/SIP/ILS/Transaction/Checkout.pm | 6 ++++-- > 2 files changed, 10 insertions(+), 6 deletions(-) > >diff --git a/C4/SIP/ILS.pm b/C4/SIP/ILS.pm >index e3bbedebb86..98422460d64 100644 >--- a/C4/SIP/ILS.pm >+++ b/C4/SIP/ILS.pm >@@ -20,7 +20,7 @@ use C4::SIP::ILS::Transaction::Hold; > use C4::SIP::ILS::Transaction::Renew; > use C4::SIP::ILS::Transaction::RenewAll; > >-use C4::Context; #BZ 18317 >+use C4::Context; #BZ 18317 > > my %supports = ( > 'magnetic media' => 1, >@@ -162,9 +162,11 @@ sub checkout { > elsif ( !$item ) { > $circ->screen_msg("Invalid Item"); > } >- elsif ( $item->{borrowernumber} >- && ! C4::Context->preference('AllowItemsOnLoanCheckoutSIP') #BZ 18317 >- && !_ci_cardnumber_cmp( $item->{borrowernumber}, $patron->borrowernumber ) ) >+ elsif ( >+ $item->{borrowernumber} >+ && !C4::Context->preference('AllowItemsOnLoanCheckoutSIP') #BZ 18317 >+ && !_ci_cardnumber_cmp( $item->{borrowernumber}, $patron->borrowernumber ) >+ ) > { > $circ->screen_msg("Item checked out to another patron"); > } >diff --git a/C4/SIP/ILS/Transaction/Checkout.pm b/C4/SIP/ILS/Transaction/Checkout.pm >index 40165a9e531..b27fcbe4ff3 100644 >--- a/C4/SIP/ILS/Transaction/Checkout.pm >+++ b/C4/SIP/ILS/Transaction/Checkout.pm >@@ -88,9 +88,11 @@ sub do_checkout { > { > $self->screen_msg("Item is on hold for another patron."); > $noerror = 0; >- } elsif ($confirmation eq 'ISSUED_TO_ANOTHER' and C4::Context->preference("AllowItemsOnLoanCheckoutSIP")) { #BZ 18317 >+ } elsif ( $confirmation eq 'ISSUED_TO_ANOTHER' and C4::Context->preference("AllowItemsOnLoanCheckoutSIP") ) >+ { > next; >- } elsif ($confirmation eq 'ISSUED_TO_ANOTHER' and ! C4::Context->preference("AllowItemsOnLoanCheckoutSIP")) { #BZ 18317 >+ } elsif ( $confirmation eq 'ISSUED_TO_ANOTHER' and !C4::Context->preference("AllowItemsOnLoanCheckoutSIP") ) >+ { > $self->screen_msg("Item already checked out to another patron. Please return item for check-in."); > $noerror = 0; > last; >-- >2.45.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18317
:
122934
|
158688
|
158689
|
159130
|
159131
|
162394
|
162395
|
162396
|
165972
|
168489
| 168490 |
168491
|
168492
|
168493