Attachment 168493 Details for Bug 18317 – Bug 18317: (QA follow-up) Fix missing `,`

[patch] Bug 18317: (QA follow-up) Fix missing `,`

Bug-18317-QA-follow-up-Fix-missing-.patch (text/plain), 1.53 KB, created by Martin Renvoize (ashimema) on 2024-07-04 08:42:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-07-04 08:42:14 UTC

Size: 1.53 KB

patch

obsolete

>From 5b100d00b0e3a25b7a5f59bfa03073bab7b3893c Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 4 Jul 2024 09:40:17 +0100
>Subject: [PATCH] Bug 18317: (QA follow-up) Fix missing `,`
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> installer/data/mysql/atomicupdate/bug_18317.pl | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_18317.pl b/installer/data/mysql/atomicupdate/bug_18317.pl
>index 8ef88b05158..a9df1490723 100755
>--- a/installer/data/mysql/atomicupdate/bug_18317.pl
>+++ b/installer/data/mysql/atomicupdate/bug_18317.pl
>@@ -1,16 +1,18 @@
> use Modern::Perl;
> 
> return {
>-    bug_number => "18317",
>-    description => "Allow check out of already checked out items through SIP"
>-    up => sub {
>+    bug_number  => "18317",
>+    description => "Allow check out of already checked out items through SIP",
>+    up          => sub {
>         my ($args) = @_;
>         my ( $dbh, $out ) = @$args{qw(dbh out)};
> 
>-        $dbh->do(q{
>+        $dbh->do(
>+            q{
>             INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
>             ('AllowItemsOnLoanCheckoutSIP','0','','Do not generate ISSUED_TO_ANOTHER warning when checking out items already checked out to someone else via SIP. This allows self checkouts for those items.','YesNo')
>-        });
>+        }
>+        );
> 
>         say $out "Added new system preference 'AllowItemsOnLoanCheckoutSIP'";
>     },
>-- 
>2.45.2

Actions: View | Diff | Splinter Review

Attachments on bug 18317: 122934 | 158688 | 158689 | 159130 | 159131 | 162394 | 162395 | 162396 | 165972 | 168489 | 168490 | 168491 | 168492 | 168493