Attachment 168505 Details for Bug 37249 – Bug 37249: disambiguate itemnumber with USING clause

[patch] Bug 37249: disambiguate itemnumber with USING clause

Bug-37249-disambiguate-itemnumber-with-USING-claus.patch (text/plain), 1.38 KB, created by Matt Blenkinsop on 2024-07-04 15:09:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2024-07-04 15:09:50 UTC

Size: 1.38 KB

patch

obsolete

>From c6fc0e838528d4765c4ee3f187ceed0bdf394e86 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 3 Jul 2024 20:39:40 +0000
>Subject: [PATCH] Bug 37249: disambiguate itemnumber with USING clause
>
>1. Do an item search that returns results
>2. Use the column filtering available at the top of the table for each column
>3. Try itemnumber, get a 500 error each time
>4. As long as there is data in the itemnumber column and you attempt to use another column you'll see a 500 error.
>5. APPLY PATCH, restart_all
>6. The itemnumber column filtering should now work as expected
>
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>---
> C4/Items.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index 519e6d1471..3041d8f13e 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -1178,7 +1178,7 @@ sub SearchItems {
>           LEFT JOIN biblio ON biblio.biblionumber = items.biblionumber
>           LEFT JOIN biblioitems ON biblioitems.biblioitemnumber = items.biblioitemnumber
>           LEFT JOIN biblio_metadata ON biblio_metadata.biblionumber = biblio.biblionumber
>-          LEFT JOIN issues ON issues.itemnumber = items.itemnumber
>+          LEFT JOIN issues USING (itemnumber)
>           WHERE 1
>     };
>     if (defined $where_str and $where_str ne '') {
>-- 
>2.39.3 (Apple Git-146)

Actions: View | Diff | Splinter Review

Attachments on bug 37249: 168478 | 168486 | 168505