Attachment 168522 Details for Bug 37254 – Bug 37254: Fix clearing of dropdown values on circulation rules

[patch] Bug 37254: Fix clearing of dropdown values on circulation rules

Bug-37254-Fix-clearing-of-dropdown-values-on-circu.patch (text/plain), 1.60 KB, created by Chris Cormack on 2024-07-04 22:12:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2024-07-04 22:12:28 UTC

Size: 1.60 KB

patch

obsolete

>From 83184e9cb26c21017422717aa4f2398b4863767c Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Thu, 4 Jul 2024 15:04:42 +0300
>Subject: [PATCH] Bug 37254: Fix clearing of dropdown values on circulation
> rules
>
>When one tries to clear the rule they are editing in circulation
>rules page via "Clear" button, dropdown selectors aren't populated
>with default value (first on the list).
>
>To reproduce:
>1. Select a rule to edit.
>2. Press "Clear" button to return edit rows values back to default values.
>=> Values in dropdowns aren't set back as default, instead they have
>same values as rule you edited before pressing "Clear".
>3. Apply this patch.
>4. Select rule to edit, then press "Clear".
>=> Dropdowns now have default values.
>
>Sponsored-by: Koha-Suomi Oy
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 960854b831c..15024a8a546 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -1464,6 +1464,7 @@
>                 }
>             });
>             $(edit_row).find("select").prop('disabled', false);
>+            $(edit_row).find("select option:selected").removeAttr('selected');
>             $(edit_row).find("select option:first-child").attr("selected", "selected");
>             $(edit_row).find("td:last input[name='clear']").remove();
>         }
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37254: 168502 | 168522 | 169582