Attachment 168561 Details for Bug 37264 – Bug 37264: Fix delete button on staff interface's suggestion detail page

[patch] Bug 37264: Fix delete button on staff interface's suggestion detail page

Bug-37264-Fix-delete-button-on-staff-interfaces-su.patch (text/plain), 2.55 KB, created by Phil Ringnalda on 2024-07-05 17:39:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Phil Ringnalda

Created: 2024-07-05 17:39:16 UTC

Size: 2.55 KB

patch

obsolete

>From 130a321937d1d69e3350c42ed2c7629b93b8148e Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 5 Jul 2024 15:52:28 +0000
>Subject: [PATCH] Bug 37264: Fix delete button on staff interface's suggestion
> detail page
>
>This patch makes a few minor changes to the suggestion detail page in
>the staff interface so that the "Delete" button looks correct and works
>correctly.
>
>To test, apply the patch and go to Suggestions in the staff interface.
>
>- If necessary, submit a suggestion. You need at least one.
>- From the suggestions management page, click the title of a suggestion.
>- At the top of this page should be two buttons, "Edit" and "Delete."
>  They should be styled consistently with each other.
>- Clicking the "Delete" button should trigger a JavaScript confirmation
>  dialog. Confirming should result in the suggestion being deleted.
>
>Sponsored-by: Athens County Public Libraries
>Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
>---
> .../prog/en/modules/suggestion/suggestion.tt              | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 5d9e0bf8f4..b93951ab07 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -100,11 +100,9 @@
>                         <a class="btn btn-default" id="editsuggestion" href="suggestion.pl?op=edit_form&amp;suggestionid=[% suggestionid | html %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a>
>                         <form class="delete_form" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl">
>                             [% INCLUDE 'csrf-token.inc' %]
>-                            <fieldset class="action">
>-                                <input type="hidden" name="op" value="cud-delete" />
>-                                <input type="hidden" name="suggestionid" value="[% suggestionid | html %]" />
>-                                <button type="submit" class="btn btn-primary">Delete</button>
>-                            </fieldset>
>+                            <input type="hidden" name="op" value="cud-delete" />
>+                            <input type="hidden" name="suggestionid" value="[% suggestionid | html %]" />
>+                            <button type="submit" class="btn btn-default deletesuggestion"><i class="fa fa-trash-can"></i> Delete</button>
>                         </form>
>                     </div>
> 
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 37264: 168558 | 168561