Attachment 168594 Details for Bug 37265 – Add UniqueItemFields in orderreceive

[patch] Add UniqueItemFields in orderreceive

Bug37265.patch (text/plain), 1.63 KB, created by Michal Dudzik on 2024-07-08 15:29:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michal Dudzik

Created: 2024-07-08 15:29:08 UTC

Size: 1.63 KB

patch

obsolete

>From 81423a7546facbc719aca8c7da3a916d9f6774e2 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Micha=C5=82=20Dudzik?= <michaldudzik@kohawbibliotece.pl>
>Date: Mon, 8 Jul 2024 17:23:45 +0200
>Subject: [PATCH] Bug 37265 - Consideration of UniqueItemFields setting when
> receiving items in an order
>
>When using the Koha acquisition module to receive items (basket receiving
>an order), Koha does not consideration of UniqueItemFields setting.
>The problem is that you can accidentally attach 3 items to an order with the same values.
>
>Test plan:
>1. Set preference UniqueItemFields: Public note (itemnotes)
>2. Go to the acquisition module.
>3. Create a basket with the option for 'Create items when:' set to receiving an order.
>4. Add an order to the basket, for example: From a new (empty) record with the Quantity set to 3 or more.
>5. Close the basket.
>6. Receive the order.
>7. Add a public note: TEST, and receive the first item (Add item).
>8. You will see that the next item has the same public note.
>9. Apply this patch and repeat step 7 - the public note is not used for the next note.
>
>Sponsored-by: kohawbibliotece.pl
>---
> acqui/orderreceive.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl
>index 550e41e810..c290326af6 100755
>--- a/acqui/orderreceive.pl
>+++ b/acqui/orderreceive.pl
>@@ -178,6 +178,7 @@ $template->param(
>     invoice               => $invoice->{invoicenumber},
>     gst_values            => \@gst_values,
>     vendor                => $bookseller,
>+    UniqueItemFields      => C4::Context->preference('UniqueItemFields'),
> );
> 
> my $patron = Koha::Patrons->find( $loggedinuser )->unblessed;
>-- 
>2.45.2.windows.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 37265: 168559 | 168594 | 168607 | 168608 | 168638 | 171949