Attachment 168690 Details for Bug 37263 – Bug 37263: Fix handling of 'All' values on 'default article request fees'

[patch] Bug 37263: Fix handling of 'All' values on 'default article request fees'

0002-Bug-37263-Fix-handling-of-All-values-on-default-arti.patch (text/plain), 1.54 KB, created by Emmi Takkinen on 2024-07-10 05:45:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emmi Takkinen

Created: 2024-07-10 05:45:06 UTC

Size: 1.54 KB

patch

obsolete

>From 8838383cca29d9890d6ad7238c52f385e5ea842a Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Fri, 5 Jul 2024 14:42:18 +0000
>Subject: [PATCH 2/4] Bug 37263: Fix handling of 'All' values on 'default
> article request fees'
>
>To test:
>1. Enable ArticleRequests sys pref
>2. Visit <staff_url>/cgi-bin/koha/admin/smart-rules.pl
>3. Under 'Default article request fees' on 'Patron category' select 'All' and input a numeric Free
>4. Click 'Add'. Notice it blows up.
>5. Apply patch. Repeat.
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index c4943b3407..208382373e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -1046,7 +1046,7 @@
>                                 [% IF ( article_request_fee.defined && article_request_fee != '' ) %]
>                                 <tr>
>                                     <td>
>-                                        [% IF c == '*' %]
>+                                        [% IF c == undef %]
>                                             <em>All</em>
>                                         [% ELSE %]
>                                             [% Categories.GetName(c) | html %]
>-- 
>2.34.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 37263: 168553 | 168591 | 168593 | 168650 | 168651 | 168652 | 168675 | 168676 | 168677 | 168690 | 168691 | 168692 | 169983 | 169984 | 169985