Attachment 168705 Details for Bug 37300 – Bug 37300: Allow modifying holds from any library again via biblio detail page

[patch] Bug 37300: Allow modifying holds from any library again via biblio detail page

0001-Bug-37300-Allow-modifying-holds-from-any-library-aga.patch (text/plain), 1.91 KB, created by Emmi Takkinen on 2024-07-10 10:05:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emmi Takkinen

Created: 2024-07-10 10:05:28 UTC

Size: 1.91 KB

patch

obsolete

>From af2f537d036e5bd46363caadaecc2ea277a8bddd Mon Sep 17 00:00:00 2001
>From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Date: Wed, 10 Jul 2024 11:53:16 +0300
>Subject: [PATCH] Bug 37300: Allow modifying holds from any library again via
> biblio detail page
>
>Currently one can no longer select item to be modified from
>biblio detail page if items hold library differs from users
>home library and home libraries of all items. Previously
>this was possible. This patch reintroduces this functionality.
>
>To test:
>1. Find biblio with items from library A and B.
>2. Change one items holding branch to branch C (either
>manually from database or transfer item through Koha).
>=> Note that you can no longer select this item and
>its row has no "Edit" button on it.
>3. Apply this patch.
>4. Refresh page.
>=> You can now select item and "Edit" button is displayed.
>
>Sponsored-by: Koha-Suomi Oy
>---
> .../en/includes/html_helpers/tables/items/catalogue_detail.inc  | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index f7ca251121..190f4952f8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -300,7 +300,7 @@
>                 searchable: false,
>                 orderable: false,
>                 render: function (data, type, row, meta) {
>-                    if ( can_edit_items_from[row.holding_library_id] ){
>+                    if ( can_edit_items_from[row.home_library_id] ){
>                         if ( items_selection[tab_id].includes(row.item_id) ) {
>                             return '<input type="checkbox" value="%s" name="itemnumber" checked />'.format(row.item_id);
>                         } else {
>-- 
>2.34.1
>

Actions: View | Diff | Splinter Review

Attachments on bug 37300: 168705 | 168890 | 168921