Attachment 168711 Details for Bug 37277 – Bug 37277: Detach identifiers on the local title list view

[patch] Bug 37277: Detach identifiers on the local title list view

Bug-37277-Detach-identifiers-on-the-local-title-li.patch (text/plain), 2.32 KB, created by Pedro Amorim on 2024-07-10 10:30:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-07-10 10:30:05 UTC

Size: 2.32 KB

patch

obsolete

>From cf0a524f2f9f609934804a7211550bc8afc23090 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 9 Jul 2024 16:30:07 +0200
>Subject: [PATCH] Bug 37277: Detach identifiers on the local title list view
>
>If a local title has both ISBN (Print) and ISBN (Online) the 2 values
>are concanetate on the same line without space on the the local title
>list view.
>
>With this patch they are now separated by a new line.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>---
> .../vue/components/ERM/EHoldingsLocalTitlesList.vue  | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue
>index 5785856ac8..2812e02fd6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue
>@@ -223,22 +223,22 @@ export default {
>                     render: function (data, type, row, meta) {
>                         let print_identifier = row.print_identifier
>                         let online_identifier = row.online_identifier
>-                        return (
>-                            (print_identifier
>+                        return [
>+                            print_identifier
>                                 ? escape_str(
>                                       __("ISBN (Print): %s").format(
>                                           print_identifier
>                                       )
>                                   )
>-                                : "") +
>-                            (online_identifier
>+                                : "",
>+                            online_identifier
>                                 ? escape_str(
>                                       __("ISBN (Online): %s").format(
>                                           online_identifier
>                                       )
>                                   )
>-                                : "")
>-                        )
>+                                : "",
>+                        ].join("<br/>")
>                     },
>                 },
>             ]
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37277: 168623 | 168664 | 168684 | 168711