Bugzilla – Attachment 168844 Details for
Bug 37309
Improve 'delete' and 'modify' links for items on the bibliographic detail page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37309: Clear itemnumbers array before 'select all'
Bug-37309-Clear-itemnumbers-array-before-select-al.patch (text/plain), 1.40 KB, created by
Pedro Amorim
on 2024-07-11 16:43:00 UTC
(
hide
)
Description:
Bug 37309: Clear itemnumbers array before 'select all'
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-07-11 16:43:00 UTC
Size:
1.40 KB
patch
obsolete
>From aa474e8ade4d26ffe62997ab5e880ab2957f4b09 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 11 Jul 2024 14:47:09 +0200 >Subject: [PATCH] Bug 37309: Clear itemnumbers array before 'select all' > >Otherwise the same itemnumber can appear several times in the array. >It could be moved to its own bug but this is only code cleaning it >seems, there is no impact on the UX > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > .../en/includes/html_helpers/tables/items/catalogue_detail.inc | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >index 3d6cd1a71f..1144657822 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >@@ -130,6 +130,7 @@ > e.preventDefault(); > let tab_id = $(this).data("tab"); > let tab = $("#"+tab_id); >+ items_selection[tab_id] = []; > tab.find("input[name='itemnumber'][type='checkbox']").each( (i, input) => { > let itemnumber = parseInt($(input).val()); > items_selection[tab_id].push(itemnumber); >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37309
:
168777
|
168797
|
168798
|
168799
|
168802
|
168844
|
168845
|
168846
|
168847
|
168848
|
170307
|
170309
|
170700