Attachment 168867 Details for Bug 33363 – Bug 33363: (QA Follow-up) Use say_success in atomic update

[patch] Bug 33363: (QA Follow-up) Use say_success in atomic update

Bug-33363-QA-Follow-up-Use-saysuccess-in-atomic-up.patch (text/plain), 1.90 KB, created by Kyle M Hall (khall) on 2024-07-11 21:46:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-07-11 21:46:26 UTC

Size: 1.90 KB

patch

obsolete

>From a4fece298cefb2b6bfdc2658535f41557b1b7b2f Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 2 Jul 2024 12:09:40 +0000
>Subject: [PATCH] Bug 33363: (QA Follow-up) Use say_success in atomic update
>
>---
> installer/data/mysql/atomicupdate/bug_33363.pl | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_33363.pl b/installer/data/mysql/atomicupdate/bug_33363.pl
>index 6f06c336b49..aef8f3a75cd 100755
>--- a/installer/data/mysql/atomicupdate/bug_33363.pl
>+++ b/installer/data/mysql/atomicupdate/bug_33363.pl
>@@ -1,4 +1,5 @@
> use Modern::Perl;
>+use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
> 
> return {
>     bug_number  => "33363",
>@@ -10,16 +11,17 @@ return {
> 
>         $dbh->do(
>             q{INSERT IGNORE INTO permissions (module_bit, code, description) VALUES (12, 'suggestions_create', 'Create purchase suggestions')}
>-        );
>+        ) && say_success($out, "Added new permissions suggestions_create");
>         $dbh->do(
>             q{INSERT IGNORE INTO permissions (module_bit, code, description) VALUES (12, 'suggestions_delete', 'Update purchase suggestions')}
>-        );
>+        ) && say_success($out, "Added new permissions suggestions_delete");
> 
>         $dbh->do(
>             q{INSERT IGNORE INTO user_permissions (borrowernumber, module_bit, code) SELECT borrowernumber, 12, 'suggestions_create' FROM borrowers WHERE flags & (1 << 2)}
>-        );
>+        ) && say_success($out, "Added new permissions suggestions_create to patrons with suggestions_manage");
>         $dbh->do(
>             q{INSERT IGNORE INTO user_permissions (borrowernumber, module_bit, code) SELECT borrowernumber, 12, 'suggestions_delete' FROM borrowers WHERE flags & (1 << 2)}
>-        );
>+        ) && say_success($out, "Added new permissions suggestions_delete to patrons with suggestions_manage");
>+
>     },
> };
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33363: 150247 | 150450 | 153177 | 160846 | 160847 | 160902 | 160903 | 165142 | 165143 | 168052 | 168053 | 168055 | 168056 | 168356 | 168357 | 168358 | 168359 | 168803 | 168804 | 168805 | 168806 | 168807 | 168808 | 168865 | 168866 | 168867 | 168868 | 168869