Bugzilla – Attachment 168890 Details for
Bug 37300
Unable to modify certain items in biblio detail page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37300: Allow modifying holds from any library again via biblio detail page
0001-Bug-37300-Allow-modifying-holds-from-any-library-aga.patch (text/plain), 2.71 KB, created by
Emmi Takkinen
on 2024-07-12 10:47:05 UTC
(
hide
)
Description:
Bug 37300: Allow modifying holds from any library again via biblio detail page
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2024-07-12 10:47:05 UTC
Size:
2.71 KB
patch
obsolete
>From d4ec6cc1d145cc239fc4a30064d235472ecec9a0 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Wed, 10 Jul 2024 11:53:16 +0300 >Subject: [PATCH] Bug 37300: Allow modifying holds from any library again via > biblio detail page > >Currently one can no longer select item to be modified from >biblio detail page if items hold library differs from users >home library and home libraries of all items. Previously >this was possible. This patch reintroduces this functionality. > >To test: >1. Find biblio with items from library A and B. >2. Change one items holding branch to branch C (either >manually from database or transfer item through Koha). >=> Note that you can no longer select this item and >its row has no "Edit" button on it. >3. Apply this patch. >4. Refresh page. >=> You can now select item and "Edit" button is displayed. > >Sponsored-by: Koha-Suomi Oy >--- > .../includes/html_helpers/tables/items/catalogue_detail.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >index 18a2c36630..a26745a8ac 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >@@ -300,7 +300,7 @@ > searchable: false, > orderable: false, > render: function (data, type, row, meta) { >- if ( can_edit_items_from[row.holding_library_id] ){ >+ if ( can_edit_items_from[row.home_library_id] ){ > if ( items_selection[tab_id].includes(row.item_id) ) { > return '<input type="checkbox" value="%s" name="itemnumber" checked />'.format(row.item_id); > } else { >@@ -752,7 +752,7 @@ > { > data: function( row, type, val, meta ) { > let nodes = ''; >- if ( can_edit_items_from[row.holding_library_id] ){ >+ if ( can_edit_items_from[row.home_library_id] ){ > [% IF Koha.Preference('LocalCoverImages') OR Koha.Preference('OPACLocalCoverImages') %] > nodes += '<div class="btn-group">'; > nodes += ' <a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=%s&itemnumber=%s#edititem"><i class="fa-solid fa-pencil"></i> %s</a><a class="btn btn-default btn-xs dropdown-toggle" data-toggle="dropdown"><span class="caret"></span></a>'.format(row.biblio_id, row.item_id, _("Edit")); >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37300
:
168705
|
168890
|
168921