Attachment 169032 Details for Bug 37368 – Bug 37368: Change library.name to library_id

[patch] Bug 37368: Change library.name to library_id

Bug-37368-Change-libraryname-to-libraryid.patch (text/plain), 1.30 KB, created by David Nind on 2024-07-16 02:06:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-07-16 02:06:39 UTC

Size: 1.30 KB

patch

obsolete

>From 0569f08b4ce39de613b0750cc66d242f5c954929 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 15 Jul 2024 21:37:06 +0000
>Subject: [PATCH] Bug 37368: Change library.name to library_id
>
>To test:
>1: update borrowers set surname = NULL where borrowernumber = 19;
>2. update borrowers set firstname = NULL where borrowernumber = 19;
>3. Perform a patron search, see the console error and the patron search never completes.
>4. APPLY PATCH and try searching again.
>5. Search completes.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc
>index ae27dd09ba..b6fdd3264e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js-patron-format.inc
>@@ -37,7 +37,7 @@
>             }
> 
>             if ( name.replace(' ', '').length == 0 ) {
>-                return _("A patron from library %s".format(patron.library.name));
>+                return _("A patron from library %s".format(patron.library_id));
>             }
> 
>             if ( config && config.hide_patron_name ) {
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37368: 169030 | 169032 | 169093 | 169095 | 169096 | 169106