Attachment 169055 Details for Bug 37342 – Bug 37342: Use get for launching authority popup

[patch] Bug 37342: Use get for launching authority popup

Bug-37342-Use-get-for-launching-authority-popup.patch (text/plain), 1.68 KB, created by Emily Lamancusa (emlam) on 2024-07-16 18:00:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emily Lamancusa (emlam)

Created: 2024-07-16 18:00:29 UTC

Size: 1.68 KB

patch

obsolete

>From 82efad634788c0909741d1217e276f221b5fbc2a Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 12 Jul 2024 12:40:08 +0000
>Subject: [PATCH] Bug 37342: Use get for launching authority popup
>
>This patch simply switches to a GET as the operation is not cud
>
>To test:
> 1 - Go to cataloging -> new record
> 2 - If not in basic editor, switch
> 3 - Go to tab 100
> 4 - Enter a name that has no authority in your system: McNotExist, Falsy
> 5 - Click 'Link authorities automatically'
> 6 - subfield 9 should turn red, and have an X and a + button
> 7 - Click the green +
> 8 - Boom
> 9 - Apply patch
>10 - Reload page and repeat (clear cache so js reloads)
>11 - Success! Authority window launches
>
>Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> .../intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt      | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 85b41b2daf..9a41b4d461 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -266,7 +266,7 @@ function addCreateAuthorityButton(tag_subfield_line, heading, tag_index) {
>         if(popup !== null) {
>             // Create a new form that will be POSTed in the new window
>             var form = $('<form>').attr({
>-            method: 'post',
>+            method: 'get',
>             action: "/cgi-bin/koha/authorities/authorities.pl",
>             target: "new_auth_popup"
>             });
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37342: 168901 | 168903 | 169055