Bugzilla – Attachment 169056 Details for
Bug 30657
Make patron attributes available via Template Toolkit in notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30657: Unit tests
Bug-30657-Unit-tests.patch (text/plain), 2.03 KB, created by
Brendan Lawlor
on 2024-07-16 18:15:47 UTC
(
hide
)
Description:
Bug 30657: Unit tests
Filename:
MIME Type:
Creator:
Brendan Lawlor
Created:
2024-07-16 18:15:47 UTC
Size:
2.03 KB
patch
obsolete
>From cbe15d47d28f100b1b50c408b84fc46e12920142 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 16 Jul 2024 16:43:53 +0100 >Subject: [PATCH] Bug 30657: Unit tests > >This patch adds some basic unit tests for dynamically added accessors >based on extended patron attributes. > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> >--- > t/db_dependent/Koha/Patron.t | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Patron.t b/t/db_dependent/Koha/Patron.t >index bad1cc1bfa..90de5c21bd 100755 >--- a/t/db_dependent/Koha/Patron.t >+++ b/t/db_dependent/Koha/Patron.t >@@ -757,7 +757,7 @@ subtest 'is_superlibrarian() tests' => sub { > > subtest 'extended_attributes' => sub { > >- plan tests => 16; >+ plan tests => 17; > > my $schema = Koha::Database->new->schema; > $schema->storage->txn_begin; >@@ -1104,11 +1104,37 @@ subtest 'extended_attributes' => sub { > > ok( $patron->extended_attributes([]), "We can set no attributes, mandatory attribute for other category not required"); > >- >+ $schema->storage->txn_rollback; > }; > >+ subtest 'attribute accessor tests' => sub { >+ plan tests => 2; >+ >+ $schema->storage->txn_begin; >+ >+ Koha::Patron::Attribute::Types->search->delete; >+ >+ my $attribute_type_1 = $builder->build_object( >+ { >+ class => 'Koha::Patron::Attribute::Types', >+ value => { code => 'smartnumber', repeatable => 0 } >+ } >+ ); >+ >+ my $patron = $builder->build_object({ class => 'Koha::Patrons' }); >+ >+ is( $patron->smartnumber, undef, 'smartnumber accessor returns undef when not set'); >+ >+ $patron->extended_attributes( >+ [ >+ { code => 'smartnumber', attribute => 'SM1234' } >+ ] >+ ); > >+ is( $patron->smartnumber, 'SM1234', 'smartnumber accessor returns value when set'); > >+ $schema->storage->txn_rollback; >+ }; > }; > > subtest 'can_log_into() tests' => sub { >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30657
:
169049
|
169050
|
169056
|
169057
|
173817
|
173818
|
173819
|
173901
|
173902
|
173910
|
173911
|
173912
|
173913
|
173914