Attachment 169072 Details for Bug 37345 – Bug 37345: Only toggle_onsite_checkout() if OnSiteCheckoutAutoCheck is enabled

[patch] Bug 37345: Only toggle_onsite_checkout() if OnSiteCheckoutAutoCheck is enabled

Bug-37345-Only-toggleonsitecheckout-if-OnSiteCheck.patch (text/plain), 1.63 KB, created by David Nind on 2024-07-17 04:21:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-07-17 04:21:23 UTC

Size: 1.63 KB

patch

obsolete

>From 5200c4da906cf427b31b155ad7f0bfabf3af5331 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 15 Jul 2024 16:20:15 +0000
>Subject: [PATCH] Bug 37345: Only toggle_onsite_checkout() if
> OnSiteCheckoutAutoCheck is enabled
>
>To test:
>1. Find an item to checkout and a patron to check out to.
>2. Set a due manually: "Specify due date (MM/DD/YYYY):"
>3. Before checking out click the "Remember for session:" checkbox.
>4. Check the item out.
>5. The specific due date is not retained.
>6. APPLY PATCH
>7. Try 1 -4 again, now the date should be sticking.
>8. Turn on the OnSiteCheckouts system pref and make sure it still works
>9. Turn on the  OnSiteCheckoutAutoCheck system pref and make sure the on-site checkbox is still checked after doing an on-site checkout.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index c7679844ff..b790401fdf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -1112,7 +1112,9 @@
>                     [% END %]
>                 }
>             });
>-            toggle_onsite_checkout();
>+            [% IF Koha.Preference('OnSiteCheckoutAutoCheck') && onsite_checkout == "on" %]
>+                toggle_onsite_checkout();
>+            [% END %]
>             $("#onsite_checkout").click(function(){
>                 toggle_onsite_checkout();
>             });
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37345: 168904 | 169010 | 169072 | 169097