Bugzilla – Attachment 169112 Details for
Bug 36694
Remove HC Sticky library in favor of CSS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36694: Add JS observer to detect stuck sticky element
Bug-36694-Add-JS-observer-to-detect-stuck-sticky-e.patch (text/plain), 1.17 KB, created by
Victor Grousset/tuxayo
on 2024-07-18 00:44:32 UTC
(
hide
)
Description:
Bug 36694: Add JS observer to detect stuck sticky element
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2024-07-18 00:44:32 UTC
Size:
1.17 KB
patch
obsolete
>From 00ec146f6cc88bfd8120f028a8f8adbe39e19740 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 24 Apr 2024 23:18:15 +0000 >Subject: [PATCH] Bug 36694: Add JS observer to detect stuck sticky element > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 10 ++++++++++ > 1 file changed, 10 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >index ceaf8b8d57..2fa567e99e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >@@ -60,6 +60,16 @@ $.fn.selectTabByID = function (tabID) { > }; > > $(document).ready(function () { >+ //check if sticky element is stuck, if so add floating class >+ if ( $('#toolbar.sticky').length ) { >+ const observer = new IntersectionObserver( >+ ([e]) => e.target.classList.toggle('floating', e.intersectionRatio < 1), >+ {threshold: [1]} >+ ); >+ >+ observer.observe(document.querySelector('.sticky')); >+ } >+ > //check for a hash before setting focus > let hash = window.location.hash; > if (!hash) { >-- >2.45.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36694
:
165489
|
165490
|
165491
|
165492
|
165493
|
165576
|
165582
|
165584
|
165587
|
165680
|
165682
|
165683
|
165684
|
165686
|
165756
|
165757
|
165758
|
165759
|
165760
|
165761
|
165762
|
165763
|
165764
|
165765
|
165766
|
165767
|
166703
|
166704
|
166705
|
166706
|
166707
|
166708
|
166709
|
166710
|
166711
|
166712
|
166713
|
166714
|
166715
|
166940
|
167507
|
167508
|
167509
|
167510
|
167511
|
167512
|
167513
|
167514
|
167515
|
167516
|
167517
|
167518
|
167519
|
167520
|
167539
|
167823
|
167824
|
167825
|
167826
|
167827
|
167828
|
167829
|
167830
|
167831
|
167832
|
167833
|
167834
|
167835
|
167836
|
167837
|
169110
|
169111
|
169112
|
169113
|
169114
|
169115
|
169116
|
169117
|
169118
|
169119
|
169120
|
169121
|
169122
|
169123
|
169124
|
169125
|
171080
|
171081
|
171082
|
171083
|
171084
|
171085
|
171086
|
171087
|
171088
|
171089
|
171090
|
171091
|
171092
|
171093
|
171094
|
171095
|
171852
|
171853
|
171854
|
171855
|
171856
|
171857
|
171858
|
171859
|
171860
|
171861
|
171862
|
171863
|
171864
|
171865
|
171866
|
171867