Bugzilla – Attachment 169131 Details for
Bug 37401
Wrong i index of inputs for 'Unlimited' values
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37401: Fix incorrect index in smart-rules.tt
Bug-37401-Fix-incorrect-index-in-smart-rulestt.patch (text/plain), 2.06 KB, created by
Peter Vashchuk
on 2024-07-18 12:43:49 UTC
(
hide
)
Description:
Bug 37401: Fix incorrect index in smart-rules.tt
Filename:
MIME Type:
Creator:
Peter Vashchuk
Created:
2024-07-18 12:43:49 UTC
Size:
2.06 KB
patch
obsolete
>From ca2f37d26a89378040932ca53498d0a51d871d8a Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Thu, 18 Jul 2024 15:43:23 +0300 >Subject: [PATCH] Bug 37401: Fix incorrect index in smart-rules.tt > >This patch corrects the index for the "Current checkouts allowed" column. > >To reproduce: >1. Go to Administration -> Circulation and Fine Rules. >2. Add or edit a rule so that "Current checkouts allowed" and "Current on-site checkouts allowed" are set to "Unlimited." >3. Press the edit button to edit that rule, and see that the text edit field for "Current on-site checkouts allowed" is empty, as it should be, while "Current checkouts allowed" has a prefilled text value "Unlimited". >4. Apply the patch. >5. Repeat the third step and ensure that this time when you edit that rule, both text edit fields for "Current checkouts allowed" and "Current on-site checkouts allowed" are correctly empty. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index d786284c3e..e63044f794 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -1563,7 +1563,7 @@ > // Remove potential previous input added > $(current_column).find("input").remove(); > $(current_column).append("<input type='hidden' name='"+name+"' value='"+val+"' />"); >- } else if ( i == 5 || i == 6 || i == 26 || i == 27 || i == 28 || current_input_id === "holds_pickup_period" ) { >+ } else if ( i == 4 || i == 5 || i == 26 || i == 27 || i == 28 || current_input_id === "holds_pickup_period" ) { > // If the value is not an integer for > // - "Current checkouts allowed" > // - "Current on-site checkouts allowed" >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37401
:
169131
|
169160