Attachment 169146 Details for Bug 37332 – Bug 37332: Fix unseen and customer renewal date parameters in svc

[patch] Bug 37332: Fix unseen and customer renewal date parameters in svc

Bug-37332-Fix-unseen-and-customer-renewal-date-par.patch (text/plain), 3.58 KB, created by Kyle M Hall (khall) on 2024-07-18 15:35:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-07-18 15:35:28 UTC

Size: 3.58 KB

patch

obsolete

>From cf7c3a5387ed96db57e41d83b2e49f115852ed53 Mon Sep 17 00:00:00 2001
>From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Date: Tue, 16 Jul 2024 10:36:23 -0400
>Subject: [PATCH] Bug 37332: Fix unseen and customer renewal date parameters in
> svc
>
>To test:
>0. Enable unseen renewals
>    i. Set the system preference UnseenRenewals to Allowed
>    ii. Edit the circulation rules to specify the maximum number of
>        unseen renewals allowed
>1. Check out an item to a patron
>2. In the checkouts table on that patron's account, check the "Renew"
>   checkbox for that item
>3. Select a custom renewal date using the Renewal due date flatpicker
>4. Check the checkbox labeled "Renew as unseen if appropriate"
>4. Click Renew selected items
>--> The item renews, but its new due date follows the renewal period
>    specified in the circulation rules, regardless of what date was
>    entered in the Renewal due date field
>--> The checkout still has all of its unseen renewals remaining,
>    indicating that the renewal was not processed as an unseen renewal
>5. Enter another custom renewal date and renew checkout with the Renew
>   all button
>--> Same result
>6. Apply patch and restart_all
>7. Repeat test plan
>--> Custom renewal date is now respected
>--> Number of unseen renewals remaining decreases when "Renew as unseen"
>    checkbox is checked
>8. Renew the item with the "Renew as unseen" checkbox unchecked
>--> Confirm that number of unseen renewals is reset (i.e. the checkout
>    once again has all of its unseen renewals remaining), indicating
>    that the renewal was processed as a "seen" renewal
>
>Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../prog/js/fetch/circulation-api-client.js   | 20 ++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/fetch/circulation-api-client.js b/koha-tmpl/intranet-tmpl/prog/js/fetch/circulation-api-client.js
>index 1eeb06824cb..4f32d5caa5c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/fetch/circulation-api-client.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/fetch/circulation-api-client.js
>@@ -33,13 +33,19 @@ export class CirculationAPIClient extends HttpClient {
>             renew: checkout =>
>                 this.post({
>                     endpoint: "renew",
>-                    body: "itemnumber=%s&borrowernumber=%s&branchcode=%s&override_limit=%s".format(
>-                        checkout.item_id,
>-                        checkout.patron_id,
>-                        checkout.library_id,
>-                        checkout.override_limit
>-                    ),
>-                    //+ ( checkout.seen !== undefined ? "&seen=%s".format(checkout.seen) : "" ) + (checkout.date_due !== undefined ? "&date_due=%s".format(checkout.date_due) : ""),
>+                    body:
>+                        "itemnumber=%s&borrowernumber=%s&branchcode=%s&override_limit=%s".format(
>+                            checkout.item_id,
>+                            checkout.patron_id,
>+                            checkout.library_id,
>+                            checkout.override_limit
>+                        ) +
>+                        (checkout.seen !== undefined
>+                            ? "&seen=%s".format(checkout.seen)
>+                            : "") +
>+                        (checkout.date_due !== undefined
>+                            ? "&date_due=%s".format(checkout.date_due)
>+                            : ""),
>                     headers: {
>                         "Content-Type":
>                             "application/x-www-form-urlencoded;charset=utf-8",
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37332: 169047 | 169048 | 169108 | 169146