Attachment 169185 Details for Bug 37389 – Bug 37389: More silly fixes

[patch] Bug 37389: More silly fixes

Bug-37389-More-silly-fixes.patch (text/plain), 1.54 KB, created by Martin Renvoize (ashimema) on 2024-07-19 09:38:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-07-19 09:38:45 UTC

Size: 1.54 KB

patch

obsolete

>From 9d2a0f298369be656794861a2da46c2530df3bc2 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 19 Jul 2024 10:38:12 +0100
>Subject: [PATCH] Bug 37389: More silly fixes
>
>---
> Koha/ILL/Requests.pm      | 8 +++++++-
> Koha/REST/Plugin/Query.pm | 2 +-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/ILL/Requests.pm b/Koha/ILL/Requests.pm
>index a8435d1b6a1..46fbc9d9ce3 100644
>--- a/Koha/ILL/Requests.pm
>+++ b/Koha/ILL/Requests.pm
>@@ -135,7 +135,13 @@ sub _build_extended_attributes_relations {
>                     "$args->{foreign_alias}.type"          => { '=', $type },
>                 };
>             },
>-            { cascade_copy => 0, cascade_delete => 0 },
>+            {
>+                accessor       => 'multi',
>+                join_type      => 'LEFT',
>+                cascade_copy   => 0,
>+                cascade_delete => 0,
>+                is_depends_on  => 0
>+            },
>         );
> 
>     }
>diff --git a/Koha/REST/Plugin/Query.pm b/Koha/REST/Plugin/Query.pm
>index d159fef0f67..fd9dcf04822 100644
>--- a/Koha/REST/Plugin/Query.pm
>+++ b/Koha/REST/Plugin/Query.pm
>@@ -183,7 +183,7 @@ Generates the DBIC join attribute based on extended_attributes query entries, an
> 
>                 # Calling our private method to build the extended attributes relations
>                 my @joins = $result_set->_build_extended_attributes_relations(\@array);
>-                push @{$ attributes->{join} }, @joins;
>+                push @{ $attributes->{join} }, @joins;
> 
>             }
>         }
>-- 
>2.45.2

Actions: View | Diff | Splinter Review

Attachments on bug 37389: 169130 | 169133 | 169140 | 169149 | 169159 | 169178 | 169185 | 169189 | 169191 | 169192 | 169234 | 169243 | 169244 | 169245 | 169246 | 169317 | 169318 | 169569 | 169570 | 169583 | 169584 | 169585 | 169586 | 169850 | 169851 | 169944 | 169945 | 169946 | 169954 | 169955 | 169956