Bugzilla – Attachment 169197 Details for
Bug 13888
'Lists' permission should allow/disallow using the lists module in staff
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13888: (follow-up) fix for create_public_lists
Bug-13888-follow-up-fix-for-createpubliclists.patch (text/plain), 1.14 KB, created by
Kyle M Hall (khall)
on 2024-07-19 11:09:46 UTC
(
hide
)
Description:
Bug 13888: (follow-up) fix for create_public_lists
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-07-19 11:09:46 UTC
Size:
1.14 KB
patch
obsolete
>From a9529f0da6590a4486f6669956ae8f86ce772389 Mon Sep 17 00:00:00 2001 >From: PerplexedTheta <jahdobble@llownd.net> >Date: Wed, 10 Jul 2024 09:02:42 +0100 >Subject: [PATCH] Bug 13888: (follow-up) fix for create_public_lists > >Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > virtualshelves/shelves.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/virtualshelves/shelves.pl b/virtualshelves/shelves.pl >index c1f1dc7640a..d52d87c30c8 100755 >--- a/virtualshelves/shelves.pl >+++ b/virtualshelves/shelves.pl >@@ -61,7 +61,7 @@ my ( $public, $shelf, $shelfnumber, @messages, $allow_transfer, $allow_create_pu > > # work out permissions once > # this check is for the create list permission >-$allow_create_public_lists = haspermission( $loggedinuser, { lists => 'create_public_lists' } ) ? 1 : 0; >+$allow_create_public_lists = haspermission( C4::Context->userenv->{id}, { lists => 'create_public_lists' } ) ? 1 : 0; > > # we want the user to be able to pick if public or private only if they are allowed > $public = ( $query->param('public') == 1 && $allow_create_public_lists == 1 ) ? 1 : 0; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13888
:
168384
|
168385
|
168386
|
168422
|
168693
|
168756
|
168757
|
168758
|
169195
|
169196
| 169197 |
169394