Bugzilla – Attachment 169210 Details for
Bug 35539
Remove unused columns from categories table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35539: Remove 'finetype' column/field from categories table
Bug-35539-Remove-finetype-columnfield-from-categor.patch (text/plain), 7.18 KB, created by
Kyle M Hall (khall)
on 2024-07-19 12:49:04 UTC
(
hide
)
Description:
Bug 35539: Remove 'finetype' column/field from categories table
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-07-19 12:49:04 UTC
Size:
7.18 KB
patch
obsolete
>From d1540669f6d8bae49f05823c3fab7377fb0cf7ff Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Tue, 2 Jan 2024 12:23:37 +0000 >Subject: [PATCH] Bug 35539: Remove 'finetype' column/field from categories > table > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/Patron/Category.pm | 1 - > .../data/mysql/en/optional/patron_categories.yml | 12 ------------ > installer/data/mysql/kohastructure.sql | 1 - > t/db_dependent/Circulation/GetHardDueDate.t | 11 +++++------ > 4 files changed, 5 insertions(+), 20 deletions(-) > >diff --git a/Koha/Patron/Category.pm b/Koha/Patron/Category.pm >index 664dcf20a54..8c0c009ee41 100644 >--- a/Koha/Patron/Category.pm >+++ b/Koha/Patron/Category.pm >@@ -287,7 +287,6 @@ sub to_api_mapping { > password_expiry_days => 'password_expiry_days', > upperagelimit => 'upper_age_limit', > dateofbirthrequired => 'lower_age_limit', >- finetype => undef, # Unused > enrolmentfee => 'enrolment_fee', > overduenoticerequired => 'overdue_notice_required', > issuelimit => undef, # Unused >diff --git a/installer/data/mysql/en/optional/patron_categories.yml b/installer/data/mysql/en/optional/patron_categories.yml >index 67dd3e1c96e..488ee9e3c4c 100644 >--- a/installer/data/mysql/en/optional/patron_categories.yml >+++ b/installer/data/mysql/en/optional/patron_categories.yml >@@ -52,7 +52,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 999 > dateofbirthrequired: 18 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 1 > issuelimit: ~ >@@ -65,7 +64,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 999 > dateofbirthrequired: 18 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 1 > issuelimit: ~ >@@ -78,7 +76,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 999 > dateofbirthrequired: 18 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 1 > issuelimit: ~ >@@ -92,7 +89,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 17 > dateofbirthrequired: 5 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 1 > issuelimit: ~ >@@ -105,7 +101,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 17 > dateofbirthrequired: 5 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 1 > issuelimit: ~ >@@ -118,7 +113,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 17 > dateofbirthrequired: 5 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 1 > issuelimit: ~ >@@ -132,7 +126,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 999 > dateofbirthrequired: 18 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 0 > issuelimit: ~ >@@ -145,7 +138,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 17 > dateofbirthrequired: 5 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 1 > issuelimit: ~ >@@ -159,7 +151,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 999 > dateofbirthrequired: 18 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 1 > issuelimit: ~ >@@ -172,7 +163,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 999 > dateofbirthrequired: 18 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 1 > issuelimit: ~ >@@ -185,7 +175,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 999 > dateofbirthrequired: 18 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 1 > issuelimit: ~ >@@ -199,7 +188,6 @@ tables: > enrolmentperiod: 99 > upperagelimit: 999 > dateofbirthrequired: 18 >- finetype: ~ > enrolmentfee: '0.000000' > overduenoticerequired: 0 > issuelimit: ~ >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 78e1efb30f2..a70ee18722a 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -1788,7 +1788,6 @@ CREATE TABLE `categories` ( > `password_expiry_days` smallint(6) DEFAULT NULL COMMENT 'number of days after which the patron must reset their password', > `upperagelimit` smallint(6) DEFAULT NULL COMMENT 'age limit for the patron', > `dateofbirthrequired` tinyint(1) DEFAULT NULL COMMENT 'the minimum age required for the patron category', >- `finetype` varchar(30) DEFAULT NULL COMMENT 'unused in Koha', > `enrolmentfee` decimal(28,6) DEFAULT NULL COMMENT 'enrollment fee for the patron', > `overduenoticerequired` tinyint(1) DEFAULT NULL COMMENT 'are overdue notices sent to this patron category (1 for yes, 0 for no)', > `issuelimit` smallint(6) DEFAULT NULL COMMENT 'unused in Koha', >diff --git a/t/db_dependent/Circulation/GetHardDueDate.t b/t/db_dependent/Circulation/GetHardDueDate.t >index bbd046a658f..8a24c64f5ce 100755 >--- a/t/db_dependent/Circulation/GetHardDueDate.t >+++ b/t/db_dependent/Circulation/GetHardDueDate.t >@@ -79,7 +79,6 @@ my $samplecat = { > enrolmentperiod => undef, > enrolmentperioddate => undef, > dateofbirthrequired => undef, >- finetype => undef, > enrolmentfee => undef, > overduenoticerequired => undef, > issuelimit => undef, >@@ -88,15 +87,15 @@ my $samplecat = { > category_type => 'A', > }; > my $query = >-"INSERT INTO categories (categorycode,description,enrolmentperiod,enrolmentperioddate,dateofbirthrequired ,finetype,enrolmentfee,overduenoticerequired,issuelimit ,reservefee ,hidelostitems ,category_type) VALUES( ?,?,?,?,?,?,?,?,?,?,?,?)"; >+"INSERT INTO categories (categorycode,description,enrolmentperiod,enrolmentperioddate,dateofbirthrequired,enrolmentfee,overduenoticerequired,issuelimit ,reservefee ,hidelostitems ,category_type) VALUES( ?,?,?,?,?,?,?,?,?,?,?)"; > $dbh->do( > $query, {}, > $samplecat->{categorycode}, $samplecat->{description}, > $samplecat->{enrolmentperiod}, $samplecat->{enrolmentperioddate}, >- $samplecat->{dateofbirthrequired}, $samplecat->{finetype}, >- $samplecat->{enrolmentfee}, $samplecat->{overduenoticerequired}, >- $samplecat->{issuelimit}, $samplecat->{reservefee}, >- $samplecat->{hidelostitems}, $samplecat->{category_type} >+ $samplecat->{dateofbirthrequired}, $samplecat->{enrolmentfee}, >+ $samplecat->{overduenoticerequired}, $samplecat->{issuelimit}, >+ $samplecat->{reservefee}, $samplecat->{hidelostitems}, >+ $samplecat->{category_type} > ); > > my $builder = t::lib::TestBuilder->new; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35539
:
160400
|
160401
|
160402
|
160403
|
160404
|
160413
|
160414
|
160415
|
160416
|
160417
|
160446
|
165724
|
169209
| 169210 |
169211
|
169212
|
169213
|
169214