Attachment 169255 Details for Bug 36169 – Bug 36169: (QA follow-up) Tidy tests

[patch] Bug 36169: (QA follow-up) Tidy tests

Bug-36169-QA-follow-up-Tidy-tests.patch (text/plain), 2.89 KB, created by Kyle M Hall (khall) on 2024-07-19 18:10:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-07-19 18:10:03 UTC

Size: 2.89 KB

patch

obsolete

>From cd9f0a0dfee9ab4891eb0e6d6e874b29f4396058 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 19 Jul 2024 13:23:10 -0400
>Subject: [PATCH] Bug 36169: (QA follow-up) Tidy tests
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> t/db_dependent/Koha/Patrons.t | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t
>index 38c744195a8..c6b48026082 100755
>--- a/t/db_dependent/Koha/Patrons.t
>+++ b/t/db_dependent/Koha/Patrons.t
>@@ -1465,27 +1465,27 @@ subtest 'is_child | is_adult' => sub {
>     );
>     $category = $builder->build_object(
>         {
>-           class => 'Koha::Patron::Categories',
>-           value => { category_type => 'S' }
>+            class => 'Koha::Patron::Categories',
>+            value => { category_type => 'S' }
>         }
>     );
>     my $patron_staff = $builder->build_object(
>         {
>-           class => 'Koha::Patrons',
>-           value => { categorycode => $category->categorycode }
>+            class => 'Koha::Patrons',
>+            value => { categorycode => $category->categorycode }
>         }
>     );
>-    is( $patron_adult->is_adult, 1, 'Patron from category A should be considered adult' );
>+    is( $patron_adult->is_adult,   1, 'Patron from category A should be considered adult' );
>     is( $patron_adult_i->is_adult, 1, 'Patron from category I should be considered adult' );
>-    is( $patron_child->is_adult, 0, 'Patron from category C should not be considered adult' );
>-    is( $patron_other->is_adult, 0, 'Patron from category O should not be considered adult' );
>-    is( $patron_staff->is_adult, 1, 'Patron from category S should be considered adult' );
>+    is( $patron_child->is_adult,   0, 'Patron from category C should not be considered adult' );
>+    is( $patron_other->is_adult,   0, 'Patron from category O should not be considered adult' );
>+    is( $patron_staff->is_adult,   1, 'Patron from category S should be considered adult' );
> 
>-    is( $patron_adult->is_child, 0, 'Patron from category A should be considered child' );
>+    is( $patron_adult->is_child,   0, 'Patron from category A should be considered child' );
>     is( $patron_adult_i->is_child, 0, 'Patron from category I should be considered child' );
>-    is( $patron_child->is_child, 1, 'Patron from category C should not be considered child' );
>-    is( $patron_other->is_child, 0, 'Patron from category O should not be considered child' );
>-    is( $patron_staff->is_child, 0, 'Patron from category S should not be considered child' );
>+    is( $patron_child->is_child,   1, 'Patron from category C should not be considered child' );
>+    is( $patron_other->is_child,   0, 'Patron from category O should not be considered child' );
>+    is( $patron_staff->is_child,   0, 'Patron from category S should not be considered child' );
> 
>     # Clean up
>     $patron_adult->delete;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36169: 162480 | 166529 | 169253 | 169254 | 169255