Bugzilla – Attachment 169394 Details for
Bug 13888
'Lists' permission should allow/disallow using the lists module in staff
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13888: (follow-up) fix tests for Virtualshelves
Bug-13888-follow-up-fix-tests-for-Virtualshelves.patch (text/plain), 1.43 KB, created by
Jake Deery
on 2024-07-23 08:16:43 UTC
(
hide
)
Description:
Bug 13888: (follow-up) fix tests for Virtualshelves
Filename:
MIME Type:
Creator:
Jake Deery
Created:
2024-07-23 08:16:43 UTC
Size:
1.43 KB
patch
obsolete
>From 531b61d20aa18be0591fd1ea0a855ba1f9d8b8bb Mon Sep 17 00:00:00 2001 >From: PerplexedTheta <jahdobble@llownd.net> >Date: Tue, 23 Jul 2024 09:13:39 +0100 >Subject: [PATCH] Bug 13888: (follow-up) fix tests for Virtualshelves > >This patch fixes failing tests resulting from oversight in the previous >attachments I supplied to this bug number. >--- > t/db_dependent/Virtualshelves.t | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/t/db_dependent/Virtualshelves.t b/t/db_dependent/Virtualshelves.t >index effd7347bf..0b8c5bf5e7 100755 >--- a/t/db_dependent/Virtualshelves.t >+++ b/t/db_dependent/Virtualshelves.t >@@ -303,6 +303,7 @@ subtest 'Shelf permissions' => sub { > my $patron4 = $builder->build( { source => 'Borrower', value => { flags => '0' } } ); > my $patron5 = $builder->build( { source => 'Borrower', value => { flags => '4' } } ); > my $sth = $dbh->prepare("INSERT INTO user_permissions (borrowernumber, module_bit, code) VALUES (?,?,?)"); >+ $sth->execute($patron2->{borrowernumber}, 20, 'edit_public_list_contents'); # $patron2 has everything checked but not superlibrarian and delete_public_lists > $sth->execute($patron4->{borrowernumber}, 20, 'edit_public_lists'); # $patron4 only has the edit_public_lists sub-permission checked > $sth->execute($patron5->{borrowernumber}, 20, 'edit_public_list_contents'); # $patron5 has the 'catalogue' permission and edit_public_list_contents sub-permission checked > >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13888
:
168384
|
168385
|
168386
|
168422
|
168693
|
168756
|
168757
|
168758
|
169195
|
169196
|
169197
| 169394