Bugzilla – Attachment 169406 Details for
Bug 9596
Allow longoverdue.pl to be configured per library on the command line
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9596: (QA follow-up) Add some clarifying comments
Bug-9596-QA-follow-up-Add-some-clarifying-comments.patch (text/plain), 1.56 KB, created by
Kyle M Hall (khall)
on 2024-07-23 10:36:11 UTC
(
hide
)
Description:
Bug 9596: (QA follow-up) Add some clarifying comments
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-07-23 10:36:11 UTC
Size:
1.56 KB
patch
obsolete
>From 0f3b59ccbb054cba371d7a5a071673f618b98e9e Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 23 Jul 2024 06:07:02 -0400 >Subject: [PATCH] Bug 9596: (QA follow-up) Add some clarifying comments > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > misc/cronjobs/longoverdue.pl | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/misc/cronjobs/longoverdue.pl b/misc/cronjobs/longoverdue.pl >index ca2a7832d0b..9aa5242616d 100755 >--- a/misc/cronjobs/longoverdue.pl >+++ b/misc/cronjobs/longoverdue.pl >@@ -387,6 +387,7 @@ my $filter_borrower_categories = ( scalar @$borrower_category || scalar @$skip_b > > my @available_branches = Koha::Libraries->search()->get_column('branchcode'); > my %branches_to_process; >+# If --branch was used, validate any branchcode passed in and mark them as branches to use > for my $lib (@branches) { > unless ( grep { $_ eq $lib } @available_branches ) { > pod2usage( >@@ -396,6 +397,7 @@ for my $lib (@branches) { > } > $branches_to_process{$lib} = 1; > } >+# If --skip-branch was used, validate any branchcode passed in and mark them as branches to *not* use > if (@skip_branches) { > for my $lib (@skip_branches) { > unless ( grep { $_ eq $lib } @available_branches ) { >@@ -406,6 +408,8 @@ if (@skip_branches) { > } > } > %branches_to_process = map { $_ => 1 } @available_branches; >+ # The mapped 0 values here will overwrite the corrosponding mapped 1 values >+ # where the 0 values exist > %branches_to_process = ( %branches_to_process, map { $_ => 0 } @skip_branches ); > } > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9596
:
162070
|
162250
|
167343
|
169405
| 169406 |
169407
|
170213
|
170222