Attachment 169421 Details for Bug 34147 – Bug 34147: Load all categories for displaying patron results

[patch] Bug 34147: Load all categories for displaying patron results

Bug-34147-Load-all-categories-for-displaying-patro.patch (text/plain), 2.07 KB, created by ByWater Sandboxes on 2024-07-23 13:36:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: ByWater Sandboxes

Created: 2024-07-23 13:36:49 UTC

Size: 2.07 KB

patch

obsolete

>From 44191c7faf908005d1e9a9606f94fe636b190b21 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 23 Jul 2024 12:51:00 +0000
>Subject: [PATCH] Bug 34147: Load all categories for displaying patron results
>
>Currently we are only loading unlimited categories into the patron search, so when we return
>patrons from a category limited to another library we crash because we don't have the descriptions
>loaded.
>
>This patch removes the limit from 'categories_map' which is only used for displaying patrons. As patron
>visibility is a feature of permissions and groups, I don't think we should enforce if based on category
>limitations.
>
>NOTE: the categories for searching are still limited in the left hand filters - but not in the dropdown if you click the options button in the top search form. This is beyond the scope of this bug.
>
>To test:
>1. Make sure you are logged in as Centerville
>2. Do a patron search for 'Ac' -- there are two patrons: Henry (Staff) and Edna (Patron)
>2. Go to Administration > Patron Categories
>3. Edit the Patron (PT) category, set the Library limitations to Fairfield only
>4. Do the patron search for 'Ac' again - it hangs up with a Processing box
>5. Apply patch
>6. Reload the page (clear cache) and confirm the results now load
>
>Signed-off-by: Jason Robb <jrobb@sekls.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>index d238a31cb3..0956c118e0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
>@@ -225,7 +225,7 @@
> 
>     <script>
>         [% SET libraries = Branches.all %]
>-        [% SET categories = Categories.limited.unblessed %]
>+        [% SET categories = Categories.all.unblessed %]
>         var categories = [% To.json(categories) | $raw %].map(e => {
>             e['_id'] = e.categorycode.toLowerCase();
>             e['_str'] = e.description;
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 34147: 169073 | 169417 | 169421 | 169559