Attachment 169465 Details for Bug 37340 – Bug 37340: Restore sorting on 'Details' column in edifactmsgs

[patch] Bug 37340: Restore sorting on 'Details' column in edifactmsgs

Bug-37340-Restore-sorting-on-Details-column-in-edi.patch (text/plain), 1.80 KB, created by Martin Renvoize (ashimema) on 2024-07-24 09:51:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-07-24 09:51:08 UTC

Size: 1.80 KB

patch

obsolete

>From 2d83a74121db3d528ca51b48eca4e0712bb68856 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 12 Jul 2024 10:23:22 +0100
>Subject: [PATCH] Bug 37340: Restore sorting on 'Details' column in edifactmsgs
>
>This patch restores the sorting options on the 'Details' field in the
>edifact messages page.
>
>We sort by basket_id followed by type behind the scenes, so the
>resulting order for a Descending sort will group by basket id highest to
>lowest with Quotes coming before Orders.
>
>This is generally what the end user actually wants to see, even though
>it may be somewhat unintuitive intially as it's not a clear alpha sort
>for what's displayed in the column in the UI.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Mary Blomley <mary.blomley@uwl.ac.uk>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt
>index 5a55f8f039f..879b4845ca1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt
>@@ -122,9 +122,10 @@
>                         }
>                     },
>                     {
>+                        "data": "basket_id:type",
>                         "title": _("Details"),
>                         "searchable": false,
>-                        "orderable": false,
>+                        "orderable": true,
>                         "render": function(data, type, row, meta) {
>                             let rendered = '';
>                             if ( row.type == 'QUOTE' || row.type == 'ORDERS' ) {
>-- 
>2.45.2

Actions: View | Diff | Splinter Review

Attachments on bug 37340: 168872 | 168923 | 169464 | 169465 | 169471