Attachment 169513 Details for Bug 37435 – Bug 37435: Fixed renew patron from moremember.pl without circulate permissions

[patch] Bug 37435: Fixed renew patron from moremember.pl without circulate permissions

Bug-37435-Fixed-renew-patron-from-morememberpl-wit.patch (text/plain), 4.46 KB, created by Roman Dolny on 2024-07-24 18:42:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Roman Dolny

Created: 2024-07-24 18:42:20 UTC

Size: 4.46 KB

patch

obsolete

>From b61943d453afe7d7b1bb7a9d18028faa5839c4e2 Mon Sep 17 00:00:00 2001
>From: Eric Garcia <cubingguy714@gmail.com>
>Date: Tue, 23 Jul 2024 18:04:41 +0000
>Subject: [PATCH] Bug 37435: Fixed renew patron from moremember.pl without
> circulate permissions
>
>To recreate:
>1. Have a staff account with limited permissions:
> -Staff access ( catalouge )
> -Add, modify and view patron information (borrowers)
> -NO circulate permissions
>2. Log in as that staff user and find a patron with an expired account.
>3. See the warning "Expiration: Patron's card has expired. Renew or Edit details".
>4. Try clicking on Renew, you are logged out and see "Error: You do not have permission to access this page."
>
>To test:
>1. Apply patch
>2. From the expired patron's details page see the warning and click Renew
>3. Notice it renews the patron and returns to the patron details page
>4. Details -> Edit -> Set the expiration date so that the patron is expired
>5. Go back to your staff patron and check 'Check out and check in items' permission
>6. In your expired patron's page -> Check out -> See warning -> Renew
>7. Notice it renews the patron and returns to the check out page
>8. Set the expired patron's expiration date so that it expires soon
>9. Uncheck 'Check out and check in items' permission for your staff patron
>10. Confirm the warning for your patron now is "Expiration: Patron's card expires on (DATE). Renew or Edit details"
>11. Repeat steps 2-7 and notice it returns to the correct pages
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>---
> .../prog/en/includes/patron_messages.inc | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>index 6c87647b42..994730c6c3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>@@ -23,7 +23,11 @@
> <li class="warndeparture">
> Expiration:
> Patron's card expires on [% patron.dateexpiry | $KohaDates %].
>- <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&amp;destination=circ&amp;reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=edit_form&amp;destination=circ&amp;borrowernumber=[% patron.borrowernumber | html %]">Edit details</a>
>+ [% IF ( moremember ) %]
>+ <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&amp;destination=member&amp;reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=edit_form&amp;destination=member&amp;borrowernumber=[% patron.borrowernumber | html %]">Edit details</a>
>+ [% ELSE %]
>+ <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&amp;destination=circe&amp;reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=edit_form&amp;destination=circ&amp;borrowernumber=[% patron.borrowernumber | html %]">Edit details</a>
>+ [% END %]
> </li>
> [% END %]
> 
>@@ -40,7 +44,11 @@
> [% IF ( expiry ) %]
> Patron's card expired on [% expiry | $KohaDates %]
> [% END %]
>- <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&amp;destination=circ&amp;reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=edit_form&amp;destination=circ&amp;borrowernumber=[% patron.borrowernumber | html %]">Edit details</a>
>+ [% IF ( moremember ) %]
>+ <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&amp;destination=member&amp;reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=edit_form&amp;destination=member&amp;borrowernumber=[% patron.borrowernumber | html %]">Edit details</a>
>+ [% ELSE %]
>+ <a href="/cgi-bin/koha/members/setstatus.pl?borrowernumber=[% patron.borrowernumber | uri %]&amp;destination=circ&amp;reregistration=y">Renew</a> or <a href="/cgi-bin/koha/members/memberentry.pl?op=edit_form&amp;destination=circ&amp;borrowernumber=[% patron.borrowernumber | html %]">Edit details</a>
>+ [% END %]
> </li>
> [% END %]
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37435: 169439 | 169513 | 169567