Bugzilla – Attachment 169546 Details for
Bug 35044
Additional fields: Allow for repeatable fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35044: (QA follow-up): Allow for value '0' in additional fields
Bug-35044-QA-follow-up-Allow-for-value-0-in-additi.patch (text/plain), 1.92 KB, created by
Pedro Amorim
on 2024-07-25 08:51:44 UTC
(
hide
)
Description:
Bug 35044: (QA follow-up): Allow for value '0' in additional fields
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-07-25 08:51:44 UTC
Size:
1.92 KB
patch
obsolete
>From dea52dc0585589d214077521889751a32b8e9b08 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Wed, 24 Jul 2024 18:15:05 +0000 >Subject: [PATCH] Bug 35044: (QA follow-up): Allow for value '0' in additional > fields > >This now allows for value '0' for an additional field (repeatable or not). >This still does not allow for an empty '' field in additional fields. >This is consistent with borrower patron attributes, i.e. if you submit an empty borrower patron attribute entry, it does not store it as empty. >Additionally, if you have a value in a borrower patron attribute but then submit the form with that field as empty, it gets deleted from the database. > >I agree not being able to save the value '0' is a blocker, but not the empty. >For consistency sake I'm keeping this as is, I don't see a use-case where a row with an empty field value is preferred over it not existing. > >If we allow for '' values of additional fields, the 'clear' button for repeatable fields would have to remove the input instead of clearing the value (or else how would the user remove repeatable fields entries?). >If this is done, it's inconsistent with the repeatable fields from patron attribute types, as in that instance the 'clear' button only removes the input contents, not the input element itself. > >prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t >--- > Koha/Object/Mixin/AdditionalFields.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Object/Mixin/AdditionalFields.pm b/Koha/Object/Mixin/AdditionalFields.pm >index 00718e99ad..80bc266b91 100644 >--- a/Koha/Object/Mixin/AdditionalFields.pm >+++ b/Koha/Object/Mixin/AdditionalFields.pm >@@ -112,7 +112,7 @@ sub prepare_cgi_additional_field_values { > push @additional_fields, { > id => $field->id, > value => $value, >- } if $value; >+ } if defined $value && $value ne ''; > } > } > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35044
:
157324
|
157325
|
157326
|
157327
|
157328
|
157329
|
157330
|
157331
|
157332
|
157333
|
157334
|
158113
|
158498
|
158499
|
158500
|
158501
|
158502
|
158503
|
158504
|
158505
|
158506
|
158507
|
158508
|
158857
|
158858
|
158859
|
158860
|
158861
|
158862
|
158863
|
158864
|
158865
|
158866
|
158867
|
158868
|
159268
|
160177
|
160178
|
160179
|
160180
|
160181
|
160182
|
160183
|
160184
|
160185
|
160186
|
160187
|
160188
|
160189
|
164162
|
164163
|
164164
|
164165
|
164166
|
164167
|
164168
|
164169
|
164170
|
164171
|
164172
|
164173
|
164174
|
167690
|
168537
|
168538
|
168539
|
168540
|
168541
|
168542
|
168543
|
168544
|
168545
|
168546
|
168547
|
168548
|
169545
|
169546
|
169547
|
169603
|
169604
|
169605
|
169606
|
169607
|
169643
|
169644
|
169645
|
169646
|
169647
|
169648
|
169649
|
169650
|
169651
|
169652
|
169653
|
169654
|
169655
|
169656
|
169657
|
169658
|
169659
|
169660
|
169661
|
169662
|
169663
|
169664
|
169665
|
169666
|
169667
|
169668
|
169669
|
169670
|
169671
|
169672
|
169673
|
169674
|
169675
|
169676
|
169677
|
169678
|
169679
|
169680
|
169681
|
169682
|
169683
|
169684
|
169697
|
170501