Attachment 169565 Details for Bug 37450 – Bug 37450: Fix 'Close basket' button from list of baskets

[patch] Bug 37450: Fix 'Close basket' button from list of baskets

Bug-37450-Fix-Close-basket-button-from-list-of-bas.patch (text/plain), 2.90 KB, created by Roman Dolny on 2024-07-25 15:09:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Roman Dolny

Created: 2024-07-25 15:09:13 UTC

Size: 2.90 KB

patch

obsolete

>From dfea2370c2c70ab8005f39a7fcf7a05d3d6addf7 Mon Sep 17 00:00:00 2001
>From: Sam Lau <samalau@gmail.com>
>Date: Wed, 24 Jul 2024 16:53:25 +0000
>Subject: [PATCH] Bug 37450: Fix 'Close basket' button from list of baskets
>
>To test:
>1) In acquisitions, have a vendor with an item (or items) in their basket. Search for this vendor.
>2) From the actions column, select the arrow and then press 'Close this basket'
>3) Clicking on this option will not close the basket and brings us to the wrong page
>4) Apply patch
>5) Try to close the basket again, and this time, it is closed successfully
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>---
> .../intranet-tmpl/prog/en/modules/acqui/booksellers.tt   | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>index 673d6d15ab..a4718b0446 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>@@ -192,7 +192,14 @@
>                                                         [% IF basket.uncertainprices %]
>                                                         <li><a href="/cgi-bin/koha/acqui/uncertainprice.pl?booksellerid=[% basket.booksellerid | uri %]&owner=1"><i class="fa-solid fa-dollar-sign"></i> Uncertain prices</a></li>
>                                                         [% ELSIF basket.total_items && !basket.is_standing %]
>-                                                        <li><a href="/cgi-bin/koha/acqui/basket.pl?op=close&basketno=[% basket.basketno | uri %]&booksellerid=[% basket.booksellerid | uri %]"><i class="fa fa-times-circle"></i> Close this basket</a></li>
>+                                                            <form method="post" action="/cgi-bin/koha/acqui/basket.pl">
>+                                                                [% INCLUDE 'csrf-token.inc' %]
>+                                                                <input type="hidden" id="basketno" value="[% basket.basketno | html %]" name="basketno" />
>+                                                                <input type="hidden" value="cud-close" name="op" />
>+                                                                <input type="hidden" name="booksellerid" value="[% basket.booksellerid | html %]" />
>+                                                                <input type="hidden" name="confirm" value="1" />
>+                                                                <li><button type="submit" class="btn btn-default"><i class="fa fa-times-circle"></i> Close this basket</button></li>
>+                                                            </form>
>                                                         [% END %]
>                                                     </ul>
>                                                 </div>
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37450: 169510 | 169565 | 170100