Attachment 169622 Details for Bug 35792 – Bug 35792: Use of uninitialized value $sub6

[patch] Bug 35792: Use of uninitialized value $sub6

Bug-35792-Use-of-uninitialized-value-sub6.patch (text/plain), 1.27 KB, created by Chris Cormack on 2024-07-25 23:05:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2024-07-25 23:05:42 UTC

Size: 1.27 KB

patch

obsolete

>From 6140d0c99b218dc50080d0b8626fd21c23ac4adb Mon Sep 17 00:00:00 2001
>From: Catalyst Bug Squasher <koha-training@catalyst.net.nz>
>Date: Thu, 25 Jul 2024 22:41:58 +0000
>Subject: [PATCH] Bug 35792: Use of uninitialized value $sub6
>
>Test plan:
>
>1. Apply patch
>2. Rerun and make sure the error "Use of uninitialized value $sub6 in pattern match (m//) at /usr/share/koha/lib/Koha/SearchEngine/Elastricsearch.pm" is no longer present.
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>
>Initial testing done, it works well, needs an additional sign off from an external party
>---
> Koha/SearchEngine/Elasticsearch.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/SearchEngine/Elasticsearch.pm b/Koha/SearchEngine/Elasticsearch.pm
>index af9bdd97a14..5ef52357202 100644
>--- a/Koha/SearchEngine/Elasticsearch.pm
>+++ b/Koha/SearchEngine/Elasticsearch.pm
>@@ -616,7 +616,7 @@ sub marc_records_to_documents {
>                 my $altscript = 0;
>                 if ($marcflavour eq 'marc21' && $tag eq '880') {
>                     my $sub6 = $field->subfield('6');
>-                    if ($sub6 =~ /^(...)-\d+/) {
>+                    if ($sub6 && $sub6 =~ /^(...)-\d+/) {
>                         $tag = $1;
>                         $altscript = 1;
>                     }
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 35792: 169619 | 169622 | 169804 | 169988