Bugzilla – Attachment 169657 Details for
Bug 35044
Additional fields: Allow for repeatable fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35044: (QA follow-up): Remove FIXME and redundant code
Bug-35044-QA-follow-up-Remove-FIXME-and-redundant-.patch (text/plain), 1.20 KB, created by
Julian Maurice
on 2024-07-26 07:49:55 UTC
(
hide
)
Description:
Bug 35044: (QA follow-up): Remove FIXME and redundant code
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2024-07-26 07:49:55 UTC
Size:
1.20 KB
patch
obsolete
>From 03bc99c25d1bd79615aa6120620030e17729660a Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Wed, 24 Jul 2024 18:31:07 +0000 >Subject: [PATCH] Bug 35044: (QA follow-up): Remove FIXME and redundant code > >prove t/db_dependent/Koha/Acquisition/Booksellers.t >prove t/db_dependent/Serials.t > >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> > >https://bugs.koha-community.org/show_bug.cgi?id=25044 >--- > C4/Serials.pm | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index a4628ac16f..c26ba89f51 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -642,10 +642,6 @@ sub SearchSubscriptions { > $subscription->{cannotdisplay} = not can_show_subscription( $subscription ); > > my $subscription_object = Koha::Subscriptions->find($subscription->{subscriptionid}); >- $subscription->{additional_fields} = { map { $_->field->name => $_->value } >- $subscription_object->additional_field_values->as_list }; >- >- #FIXME: The above $subscription->{additional_fields} may be redundant. Remove if so. > $subscription->{additional_field_values} = $subscription_object->get_additional_field_values_for_template; > } > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35044
:
157324
|
157325
|
157326
|
157327
|
157328
|
157329
|
157330
|
157331
|
157332
|
157333
|
157334
|
158113
|
158498
|
158499
|
158500
|
158501
|
158502
|
158503
|
158504
|
158505
|
158506
|
158507
|
158508
|
158857
|
158858
|
158859
|
158860
|
158861
|
158862
|
158863
|
158864
|
158865
|
158866
|
158867
|
158868
|
159268
|
160177
|
160178
|
160179
|
160180
|
160181
|
160182
|
160183
|
160184
|
160185
|
160186
|
160187
|
160188
|
160189
|
164162
|
164163
|
164164
|
164165
|
164166
|
164167
|
164168
|
164169
|
164170
|
164171
|
164172
|
164173
|
164174
|
167690
|
168537
|
168538
|
168539
|
168540
|
168541
|
168542
|
168543
|
168544
|
168545
|
168546
|
168547
|
168548
|
169545
|
169546
|
169547
|
169603
|
169604
|
169605
|
169606
|
169607
|
169643
|
169644
|
169645
|
169646
|
169647
|
169648
|
169649
|
169650
|
169651
|
169652
|
169653
|
169654
|
169655
|
169656
|
169657
|
169658
|
169659
|
169660
|
169661
|
169662
|
169663
|
169664
|
169665
|
169666
|
169667
|
169668
|
169669
|
169670
|
169671
|
169672
|
169673
|
169674
|
169675
|
169676
|
169677
|
169678
|
169679
|
169680
|
169681
|
169682
|
169683
|
169684
|
169697
|
170501