Attachment 169680 Details for Bug 35044 – Bug 35044: (QA follow-up): Remove useless code

[patch] Bug 35044: (QA follow-up): Remove useless code

Bug-35044-QA-follow-up-Remove-useless-code.patch (text/plain), 1.46 KB, created by Julian Maurice on 2024-07-26 07:53:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Julian Maurice

Created: 2024-07-26 07:53:45 UTC

Size: 1.46 KB

patch

obsolete

>From ed321555274f03565dce3d4926abeb4675d2de1c Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Thu, 25 Jul 2024 16:43:12 +0000
>Subject: [PATCH] Bug 35044: (QA follow-up): Remove useless code
>
>Most definitely a copy paste error. I've tested and retested this
>particular JS piece of code, works as intended before and after removing
>this badly copy pasted code. I'm surprised this wasn't causing a console
>error.
>
>Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
>---
> .../intranet-tmpl/prog/en/modules/admin/additional-fields.tt    | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt
>index 22499ca66a..aa8556dad9 100755
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt
>@@ -311,7 +311,7 @@
>                         alert(_("You cannot select an authorised value category and a MARC field") );
>                         return false;
>                     }
>-                } $("#repeatable").prop('checked') == true
>+                }
>                 if ( $("#marcfield").length && $("#repeatable").length) {
>                     if ( $("#marcfield").val().length > 0 && $("#repeatable").prop('checked') == true ) {
>                         alert(_("You cannot set a MARC field as repeatable") );
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 35044: 157324 | 157325 | 157326 | 157327 | 157328 | 157329 | 157330 | 157331 | 157332 | 157333 | 157334 | 158113 | 158498 | 158499 | 158500 | 158501 | 158502 | 158503 | 158504 | 158505 | 158506 | 158507 | 158508 | 158857 | 158858 | 158859 | 158860 | 158861 | 158862 | 158863 | 158864 | 158865 | 158866 | 158867 | 158868 | 159268 | 160177 | 160178 | 160179 | 160180 | 160181 | 160182 | 160183 | 160184 | 160185 | 160186 | 160187 | 160188 | 160189 | 164162 | 164163 | 164164 | 164165 | 164166 | 164167 | 164168 | 164169 | 164170 | 164171 | 164172 | 164173 | 164174 | 167690 | 168537 | 168538 | 168539 | 168540 | 168541 | 168542 | 168543 | 168544 | 168545 | 168546 | 168547 | 168548 | 169545 | 169546 | 169547 | 169603 | 169604 | 169605 | 169606 | 169607 | 169643 | 169644 | 169645 | 169646 | 169647 | 169648 | 169649 | 169650 | 169651 | 169652 | 169653 | 169654 | 169655 | 169656 | 169657 | 169658 | 169659 | 169660 | 169661 | 169662 | 169663 | 169664 | 169665 | 169666 | 169667 | 169668 | 169669 | 169670 | 169671 | 169672 | 169673 | 169674 | 169675 | 169676 | 169677 | 169678 | 169679 | 169680 | 169681 | 169682 | 169683 | 169684 | 169697 | 170501