Bugzilla – Attachment 169697 Details for
Bug 35044
Additional fields: Allow for repeatable fields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35044: (QA follow-up): Fix flaky tests
Bug-35044-QA-follow-up-Fix-flaky-tests.patch (text/plain), 1.36 KB, created by
Pedro Amorim
on 2024-07-26 13:09:07 UTC
(
hide
)
Description:
Bug 35044: (QA follow-up): Fix flaky tests
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-07-26 13:09:07 UTC
Size:
1.36 KB
patch
obsolete
>From a5eb5115f21a44a4ee73ad95c3de620268570fed Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 26 Jul 2024 13:05:17 +0000 >Subject: [PATCH] Bug 35044: (QA follow-up): Fix flaky tests > >To test, run the following test file a couple times until it fails: >prove t/db_dependent/Koha/Object/Mixin/AdditionalFields.t > >My testing this failed around 50% of the time so it should not take >long to reproduce. I believe this is because the order of the array >elements may differ. > >Apply this patch and run the test file again many times. It should >never fail. >--- > Koha/Object/Mixin/AdditionalFields.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/Koha/Object/Mixin/AdditionalFields.pm b/Koha/Object/Mixin/AdditionalFields.pm >index 18bc782bc0..90f8ab087f 100644 >--- a/Koha/Object/Mixin/AdditionalFields.pm >+++ b/Koha/Object/Mixin/AdditionalFields.pm >@@ -104,7 +104,8 @@ sub prepare_cgi_additional_field_values { > my ( $self, $cgi, $tablename ) = @_; > > my @additional_fields; >- my $table_fields = Koha::AdditionalFields->search( { tablename => $tablename } ); >+ my $table_fields = >+ Koha::AdditionalFields->search( { tablename => $tablename }, { order_by => { -asc => 'id' } } ); > > while ( my $field = $table_fields->next ) { > my @field_values = $cgi->multi_param( 'additional_field_' . $field->id ); >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35044
:
157324
|
157325
|
157326
|
157327
|
157328
|
157329
|
157330
|
157331
|
157332
|
157333
|
157334
|
158113
|
158498
|
158499
|
158500
|
158501
|
158502
|
158503
|
158504
|
158505
|
158506
|
158507
|
158508
|
158857
|
158858
|
158859
|
158860
|
158861
|
158862
|
158863
|
158864
|
158865
|
158866
|
158867
|
158868
|
159268
|
160177
|
160178
|
160179
|
160180
|
160181
|
160182
|
160183
|
160184
|
160185
|
160186
|
160187
|
160188
|
160189
|
164162
|
164163
|
164164
|
164165
|
164166
|
164167
|
164168
|
164169
|
164170
|
164171
|
164172
|
164173
|
164174
|
167690
|
168537
|
168538
|
168539
|
168540
|
168541
|
168542
|
168543
|
168544
|
168545
|
168546
|
168547
|
168548
|
169545
|
169546
|
169547
|
169603
|
169604
|
169605
|
169606
|
169607
|
169643
|
169644
|
169645
|
169646
|
169647
|
169648
|
169649
|
169650
|
169651
|
169652
|
169653
|
169654
|
169655
|
169656
|
169657
|
169658
|
169659
|
169660
|
169661
|
169662
|
169663
|
169664
|
169665
|
169666
|
169667
|
169668
|
169669
|
169670
|
169671
|
169672
|
169673
|
169674
|
169675
|
169676
|
169677
|
169678
|
169679
|
169680
|
169681
|
169682
|
169683
|
169684
| 169697 |
170501