Bugzilla – Attachment 169699 Details for
Bug 36196
Handling NULL data in ajax calls for cities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36196: Handling NULL data on ajax call
Bug-36196-Handling-NULL-data-on-ajax-call.patch (text/plain), 1.61 KB, created by
Martin Renvoize (ashimema)
on 2024-07-26 13:16:05 UTC
(
hide
)
Description:
Bug 36196: Handling NULL data on ajax call
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-07-26 13:16:05 UTC
Size:
1.61 KB
patch
obsolete
>From a4d87ed9fa243a0fa9faba27ddcbdb5b9883072f Mon Sep 17 00:00:00 2001 >From: Thibaud Guillot <thibaud.guillot@biblibre.com> >Date: Wed, 28 Feb 2024 16:20:10 +0100 >Subject: [PATCH] Bug 36196: Handling NULL data on ajax call > >Test plan: > >1) Update some data in your cities table, sample for one send: >"UPDATE cities SET city_state=NULL WHERE cityid=<id>" >2) Go on "/cgi-bin/koha/admin/cities.pl" and wait a entire life :) >3) Apply this patch >4) Rebuild your po files if needed >5) Reload the same page and now you get normally the datatable > >Sponsored by: BibLibre >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >index 5de5ef11620..2243f74ff30 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt >@@ -243,7 +243,11 @@ > "targets": [0,1,2,3,4], > "render": function (data, type, row, meta) { > if ( type == 'display' ) { >- return data.escapeHtml(); >+ if ( data != null ) { >+ return data.escapeHtml(); >+ } else { >+ return ""; >+ } > } > return data; > } >-- >2.45.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36196
:
162535
|
162551
|
162552
| 169699