Attachment 169722 Details for Bug 37476 – Bug 37476: Unit tests

[patch] Bug 37476: Unit tests

Bug-37476-Unit-tests.patch (text/plain), 3.55 KB, created by Martin Renvoize (ashimema) on 2024-07-26 13:47:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-07-26 13:47:55 UTC

Size: 3.55 KB

patch

obsolete

>From d33fa70c6363dfb7cc3ec86dc0017e2d6cc97bdc Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 25 Jul 2024 13:50:30 -0300
>Subject: [PATCH] Bug 37476: Unit tests
>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Serials.t | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t
>index da919c5f793..0c9ce3dffef 100755
>--- a/t/db_dependent/Serials.t
>+++ b/t/db_dependent/Serials.t
>@@ -5,7 +5,7 @@
> 
> use Modern::Perl;
> 
>-use C4::Serials qw( updateClaim NewSubscription GetSubscription GetSubscriptionHistoryFromSubscriptionId SearchSubscriptions ModSubscription GetExpirationDate GetSerials GetSerialInformation NewIssue AddItem2Serial DelSubscription GetFullSubscription PrepareSerialsData GetSubscriptionsFromBiblionumber ModSubscriptionHistory GetSerials2 GetLatestSerials GetNextSeq GetSeq CountSubscriptionFromBiblionumber ModSerialStatus findSerialsByStatus HasSubscriptionStrictlyExpired HasSubscriptionExpired GetLateOrMissingIssues check_routing addroutingmember GetNextDate );
>+use C4::Serials qw( getroutinglist updateClaim NewSubscription GetSubscription GetSubscriptionHistoryFromSubscriptionId SearchSubscriptions ModSubscription GetExpirationDate GetSerials GetSerialInformation NewIssue AddItem2Serial DelSubscription GetFullSubscription PrepareSerialsData GetSubscriptionsFromBiblionumber ModSubscriptionHistory GetSerials2 GetLatestSerials GetNextSeq GetSeq CountSubscriptionFromBiblionumber ModSerialStatus findSerialsByStatus HasSubscriptionStrictlyExpired HasSubscriptionExpired GetLateOrMissingIssues check_routing addroutingmember GetNextDate );
> use C4::Serials::Frequency;
> use C4::Serials::Numberpattern;
> use C4::Biblio qw( AddBiblio GetMarcFromKohaField );
>@@ -17,7 +17,7 @@ use Koha::Acquisition::Booksellers;
> use t::lib::Mocks;
> use t::lib::TestBuilder;
> use Test::MockModule;
>-use Test::More tests => 57;
>+use Test::More tests => 63;
> 
> BEGIN {
>     use_ok('C4::Serials', qw( updateClaim NewSubscription GetSubscription GetSubscriptionHistoryFromSubscriptionId SearchSubscriptions ModSubscription GetExpirationDate GetSerials GetSerialInformation NewIssue AddItem2Serial DelSubscription GetFullSubscription PrepareSerialsData GetSubscriptionsFromBiblionumber ModSubscriptionHistory GetSerials2 GetLatestSerials GetNextSeq GetSeq CountSubscriptionFromBiblionumber ModSerialStatus findSerialsByStatus HasSubscriptionStrictlyExpired HasSubscriptionExpired GetLateOrMissingIssues check_routing addroutingmember GetNextDate ));
>@@ -227,6 +227,15 @@ my $patronid2 = $patron2->borrowernumber;
> addroutingmember( $patronid1, $subscriptionwithroutinglistid );
> addroutingmember( $patronid2, $subscriptionwithroutinglistid );
> 
>+my @routinglist = getroutinglist($subscriptionwithroutinglistid);
>+
>+is( scalar @routinglist,               2,             'Two members on the routing list' );
>+is( $routinglist[0]->{biblionumber},   $biblionumber, 'biblionumber is correct' );
>+is( $routinglist[1]->{biblionumber},   $biblionumber, 'biblionumber is correct' );
>+is( $routinglist[0]->{borrowernumber}, $patronid1,    'First patron added has the lowest rank' );
>+is( $routinglist[0]->{ranking},        1,             'Rank 1 set for first subscription list member' );
>+is( $routinglist[1]->{ranking},        2, 'Next rank value set for the second added subscription list member' );
>+
> # Perform SearchSubscriptions
> my $fake_subscription = GetSubscription($subscriptionwithroutinglistid);
> 
>-- 
>2.45.2

Actions: View | Diff | Splinter Review

Attachments on bug 37476: 169609 | 169610 | 169702 | 169703 | 169722 | 169723