Attachment 169731 Details for Bug 35287 – Bug 35287: Preparation: AdditionalFields License Mixin

[patch] Bug 35287: Preparation: AdditionalFields License Mixin

Bug-35287-Preparation-AdditionalFields-License-Mix.patch (text/plain), 1.50 KB, created by Pedro Amorim on 2024-07-26 14:30:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-07-26 14:30:49 UTC

Size: 1.50 KB

patch

obsolete

>From b77cfdc84d68f478b9ee907abac50d48072f158c Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Wed, 8 Nov 2023 11:32:10 -0100
>Subject: [PATCH] Bug 35287: Preparation: AdditionalFields License Mixin
>
>Koha::Object::Mixin::AdditionalFields needs to come before Koha::Object
>in the inheritance so that the strings_map method that is called is
>the one from Mixin and not from Koha::Object.
>This is only required for Koha classes implementing the AdditionalFields Mixin and expose data through the REST API, because strings_map is implement in both the aforementioned classes
>
>Signed-off-by: Edith Speller <edith.speller@ukhsa.gov.uk>
>Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
>---
> Koha/ERM/License.pm  | 2 +-
> Koha/ERM/Licenses.pm | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/ERM/License.pm b/Koha/ERM/License.pm
>index 412dd9da3a..d690fe24ab 100644
>--- a/Koha/ERM/License.pm
>+++ b/Koha/ERM/License.pm
>@@ -19,7 +19,7 @@ use Modern::Perl;
> 
> use Koha::Database;
> 
>-use base qw(Koha::Object);
>+use base qw(Koha::Object::Mixin::AdditionalFields Koha::Object);
> 
> use Koha::Acquisition::Bookseller;
> use Koha::ERM::UserRoles;
>diff --git a/Koha/ERM/Licenses.pm b/Koha/ERM/Licenses.pm
>index c45af4d785..b1619ee63c 100644
>--- a/Koha/ERM/Licenses.pm
>+++ b/Koha/ERM/Licenses.pm
>@@ -22,7 +22,7 @@ use Koha::Database;
> 
> use Koha::ERM::License;
> 
>-use base qw(Koha::Objects);
>+use base qw(Koha::Objects Koha::Objects::Mixin::AdditionalFields);
> 
> =head1 NAME
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 35287: 158725 | 158726 | 158727 | 158728 | 158729 | 158730 | 158731 | 158732 | 158733 | 158734 | 159634 | 159635 | 159636 | 159637 | 159638 | 159639 | 159640 | 159641 | 159642 | 159643 | 165451 | 165637 | 165638 | 165639 | 165640 | 165641 | 165642 | 165643 | 165644 | 165645 | 165646 | 165647 | 167681 | 169728 | 169729 | 169730 | 169731 | 169732 | 169733 | 169734 | 169735 | 169736 | 169737 | 170448 | 170753 | 172850 | 172851 | 172852 | 172853 | 172854 | 172855 | 172856 | 172857 | 172858 | 172860 | 172861 | 173022 | 173102 | 173103 | 173104 | 173105 | 173106 | 173107 | 173108 | 173109 | 173110 | 173111 | 173112 | 173113 | 173290