Attachment 169757 Details for Bug 33668 – Bug 33668: (follow-up) Tidy up the code

[patch] Bug 33668: (follow-up) Tidy up the code

Bug-33668-follow-up-Tidy-up-the-code.patch (text/plain), 2.04 KB, created by Roman Dolny on 2024-07-26 16:32:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Roman Dolny

Created: 2024-07-26 16:32:29 UTC

Size: 2.04 KB

patch

obsolete

>From 7b89367476714d8e45038b77b0bf4021aadc8d7d Mon Sep 17 00:00:00 2001
>From: Andreas Roussos <a.roussos@dataly.gr>
>Date: Wed, 24 Jul 2024 18:17:23 +0000
>Subject: [PATCH] Bug 33668: (follow-up) Tidy up the code
>
>Added spaces around the argument to translateY() as per
>the rest of the code.
>
>Fixed indentation.
>
>Removed a stray space before closing parenthesis.
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>---
> koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/js/global.js      | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>index ce994d9afb..19b72f42cf 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
>@@ -691,7 +691,7 @@ th {
>         position: absolute;
>         right: 20px;
>         top: 50%;
>-        transform: translateY(-50%);
>+        transform: translateY( -50% );
>         cursor: pointer;
>         color: #999;
>     }
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/global.js b/koha-tmpl/opac-tmpl/bootstrap/js/global.js
>index 715233b8ea..db2cb7b69a 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/js/global.js
>+++ b/koha-tmpl/opac-tmpl/bootstrap/js/global.js
>@@ -253,14 +253,14 @@ function setPlaceholder(){
>     let search_placeholder = $("#masthead_search option:selected").data("placeholder");
>     let clearButton = $('<span class="clear-search"><i class="fa-sharp fa-regular fa-circle-xmark"></i></span>');
> 
>-    $("#translControl1").attr("placeholder", search_placeholder ).after(clearButton);
>+    $("#translControl1").attr("placeholder", search_placeholder).after(clearButton);
> 
>-       clearButton.click(function() {
>+    clearButton.click(function() {
>         $("#translControl1").val('').focus();
>         $(this).hide();
>     });
> 
>- $("#translControl1").on('input', function() {
>+    $("#translControl1").on('input', function() {
>         if ($(this).val() !== '') {
>             clearButton.show();
>         } else {
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 33668: 150602 | 169443 | 169444 | 169445 | 169446 | 169525 | 169526 | 169527 | 169528 | 169529 | 169530 | 169531 | 169532 | 169533 | 169534 | 169716 | 169717 | 169755 | 169756 | 169757 | 169758 | 169759 | 169760 | 169761