Attachment 169802 Details for Bug 37466 – Bug 37466: Add correct filter for sort_by in results.tt

[patch] Bug 37466: Add correct filter for sort_by in results.tt

Bug-37466-Add-correct-filter-for-sortby-in-results.patch (text/plain), 2.95 KB, created by Aleisha Amohia on 2024-07-28 23:59:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2024-07-28 23:59:21 UTC

Size: 2.95 KB

patch

obsolete

>From 7682ae333ea912c14d79ec6085c47282c929dd45 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Thu, 25 Jul 2024 06:44:37 +0000
>Subject: [PATCH] Bug 37466: Add correct filter for sort_by in results.tt
>
>This patch replaces the $raw filter with the correct uri filter
>for the sort_by in results.tt
>
>Test plan:
>1. Apply patch
>2. Go to /cgi-bin/koha/catalogue/search.pl?count=20&sort_by=popularity_dsc&idx=kw&q=1
>3. Click on "Edit this search"
>4. Note that the "Popularity (most to least)" Sort by option is selected
>5. Go to /cgi-bin/koha/catalogue/search.pl?count=20&sort_by=popularity_dsc&idx=kw&q=24y24ty2498294t9824yt9y23
>6. Click on "Edit this search"
>7. Note that the "Popularity (most to least)" Sort by option is selected
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index 91db336895a..758cd4cb838 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -86,7 +86,7 @@
>                     </h3>
> 
>                 [% UNLESS scan %]
>-                    <a href="/cgi-bin/koha/catalogue/search.pl?advsearch=1&edit_search=1&[% query_cgi | $raw %]&[% limit_cgi | $raw %]&sort_by=[% sort_by | $raw %]">Edit this search</a>
>+                    <a href="/cgi-bin/koha/catalogue/search.pl?advsearch=1&edit_search=1&[% query_cgi | $raw %]&[% limit_cgi | $raw %]&sort_by=[% sort_by | uri %]">Edit this search</a>
>                     [% IF ( Koha.Preference('SavedSearchFilters') && CAN_user_parameters_manage_search_filters ) %]
>                         | <a href="#" id="save_search_filter">Save search as filter</a>
>                     [% END %]
>@@ -371,7 +371,7 @@
>                             [% IF CAN_user_acquisition_order_manage && searchtoorder_basketno && searchtoorder_vendorid %][%# Coming from the basket or vendor view %]
>                                 <p><a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% searchtoorder_basketno | uri %]">View basket<a></p>
>                             [% END %]
>-                            <a href="/cgi-bin/koha/catalogue/search.pl?advsearch=1&edit_search=1&[% query_cgi | $raw %]&[% limit_cgi | $raw %]&sort_by=[% sort_by | $raw %]">Edit this search</a>
>+                            <a href="/cgi-bin/koha/catalogue/search.pl?advsearch=1&edit_search=1&[% query_cgi | $raw %]&[% limit_cgi | $raw %]&sort_by=[% sort_by | uri %]">Edit this search</a>
>                             [% IF ( Koha.Preference('SavedSearchFilters') && CAN_user_parameters_manage_search_filters ) %]
>                                 | <a href="#" id="save_search_filter">Save search as filter</a>
>                             [% END %]
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37466: 169539 | 169540 | 169799 | 169802