Attachment 169844 Details for Bug 25947 – Bug 25947: Improve locked account message

[patch] Bug 25947: Improve locked account message

Bug-25947-Improve-locked-account-message.patch (text/plain), 3.91 KB, created by Baptiste Wojtkowski (bwoj) on 2024-07-29 15:05:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Baptiste Wojtkowski (bwoj)

Created: 2024-07-29 15:05:16 UTC

Size: 3.91 KB

patch

obsolete

>From e73f5517bfc1b9956195b24f9980f5ebf596f597 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 29 Jul 2024 16:33:41 +0200
>Subject: [PATCH] Bug 25947: Improve locked account message
>
>When using system preference 'FailedLoginAttempts', a patron's account is blocked after X many failed login attempts on the OPAC.
>
>This patch adds, like for "Patron's card has expired" message :
> * a message "Patron's account has been locked (due to X failed login attempts)" on the patron details and circulation pages
> * a link to change password
>Links are only displayed if libarian has permission to edit patrons.
>
>For administrative lock, only a message is displayed :
>"Patron's account has been administratively locked"
>
>To test:
>1. Change system preference 'FailedLoginAttempts' to a small number, like 2
>2. Go to a patron's account and copy their username (while you're there, change the password and add some fines, too)
>3. In the OPAC, try to log in with the username and a wrong password 3 times
>4. Go back to the patron's account in the staff interface
>5. Note that there is a message : "Patron's account has been locked (due to 3 failed login attempts)"
>6. Click on "Change password", you go to change password page
>---
> .../prog/en/includes/patron_messages.inc | 21 ++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>index 1c32d87..cce5753 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc
>@@ -5,7 +5,7 @@
> [% SET return_claims = patron.return_claims %]
> [% SET logged_in_branchcode = Branches.GetLoggedInBranchcode() %]
> 
>-[% IF ( has_modifications || warndeparture || returnbeforeexpiry || expired || patron.gonenoaddress || patron.lost || userdebarred || odues || ( return_claims.count > ClaimReturnedWarningThreshold ) || age_limitations || limited_category || charges || charges_guarantors_guarantees || charges_guarantees || credits ) %]
>+[% IF ( has_modifications || warndeparture || returnbeforeexpiry || expired || patron.gonenoaddress || patron.lost || userdebarred || odues || ( return_claims.count > ClaimReturnedWarningThreshold ) || age_limitations || limited_category || charges || charges_guarantors_guarantees || charges_guarantees || credits || patron.account_locked) %]
> <h3>Attention</h3>
> <ul>
> [% IF ( has_modifications ) %]
>@@ -52,6 +52,25 @@
> </li>
> [% END %]
> 
>+ [% IF patron.account_locked %]
>+ [% IF patron.login_attempts < 0 %]
>+ <li class="blocker account_admin_locked">
>+ Locked: Patron's account has been administratively locked
>+ </li>
>+ [% ELSE %]
>+ <li class="blocker account_locked">
>+ Locked: Patron's account has been locked (due to [% patron.login_attempts | html %] failed login attempts)
>+ [% IF CAN_user_borrowers_edit_borrowers %]
>+ 
>+ <a href="/cgi-bin/koha/members/member-password.pl?member=[% patron.borrowernumber | html %]">Change password</a>
>+ 
>+ [% END %]
>+ </li>
>+ [% END %]
>+ [% END %]
>+
>+
>+
> [% IF ( patron.gonenoaddress ) %]
> <li class="gonenoaddress blocker">
> Address: Patron's address flagged as in doubt <a class="btn btn-default btn-xs" href="/cgi-bin/koha/members/memberentry.pl?op=edit_form&amp;borrowernumber=[% patron.borrowernumber | uri %]&amp;step=3#memberentry_account_flags"> Edit</a>
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 25947: 106643 | 145502 | 145503 | 145589 | 145878 | 147683 | 169844 | 169853 | 169864 | 174271 | 174272