Attachment 169852 Details for Bug 37463 – Bug 37463: Adding system preference.

[patch] Bug 37463: Adding system preference.

Bug-37463-Adding-system-preference.patch (text/plain), 4.42 KB, created by Danyon Sewell on 2024-07-30 01:33:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Danyon Sewell

Created: 2024-07-30 01:33:36 UTC

Size: 4.42 KB

patch

obsolete

>From 52fd45cdfe97106318cda82b2d0e86220f56095c Mon Sep 17 00:00:00 2001
>From: danyonsewell <danyonsewell@catalyst.net.nz>
>Date: Tue, 30 Jul 2024 01:32:47 +0000
>Subject: [PATCH] Bug 37463: Adding system preference.
>
>---
> ...bug_37463-add_SCOCoverImagesCategories_syspref.pl |  4 +++-
> installer/data/mysql/mandatory/sysprefs.sql          |  2 +-
> .../en/modules/admin/preferences/circulation.pref    | 12 +++++-------
> 3 files changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_37463-add_SCOCoverImagesCategories_syspref.pl b/installer/data/mysql/atomicupdate/bug_37463-add_SCOCoverImagesCategories_syspref.pl
>index 40779ae7682..1fd0c7747bd 100644
>--- a/installer/data/mysql/atomicupdate/bug_37463-add_SCOCoverImagesCategories_syspref.pl
>+++ b/installer/data/mysql/atomicupdate/bug_37463-add_SCOCoverImagesCategories_syspref.pl
>@@ -7,6 +7,8 @@ return {
>         my ($args) = @_;
>         my ($dbh, $out) = @$args{qw(dbh out)};
> 
>-        $dbh->do(q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SCOCoverImagesCategories', '1', NULL, 'Cover images will show for checked out items in the self checkout module for selected patron categories:', 'YesNo')});
>+        $dbh->do(q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('SCOCoverImagesCategories', '', NULL, 'Cover images will show for checked out items in the self checkout module for selected patron categories:', 'Free')});
>+    
>+        say $out "Added system preference 'SCOCoverImagesCategories'";
>     },
> };
>diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
>index 66e9632c999..1f7fc689999 100644
>--- a/installer/data/mysql/mandatory/sysprefs.sql
>+++ b/installer/data/mysql/mandatory/sysprefs.sql
>@@ -685,7 +685,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('SavedSearchFilters', '0', NULL, 'Allow staff with permission to create/edit custom search filters', 'YesNo'),
> ('SCOAllowCheckin','0','','If enabled, patrons may return items through the Web-based Self Checkout','YesNo'),
> ('SCOBatchCheckoutsValidCategories','',NULL,'Patron categories allowed to checkout in a batch while logged into Self Checkout','Free'),
>-('SCOCoverImagesCategories', '1', NULL, 'Cover images will show for checked out items in the self checkout module for selected patron categories:', 'YesNo'),
>+('SCOCoverImagesCategories', '', NULL, 'Cover images will show for checked out items in the self checkout module for selected patron categories:', 'Free'),
> ('SCOLoadCheckoutsByDefault','1','','If enabled, load the list of a patrons checkouts when they log in to the Self Checkout','YesNo'),
> ('SCOUserCSS','',NULL,'Add CSS to be included in the SCO module in an embedded <style> tag.','free'),
> ('SCOUserJS','',NULL,'Define custom javascript for inclusion in the SCO module','free'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index f59446c9cb6..214ccc6dc2b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -1213,13 +1213,6 @@ Circulation:
>               syntax: javascript
>               class: code
>     Self check-out module:
>-        -
>-            - pref: SCOCoverImagesCategories
>-              choices:
>-                  1: Include
>-                  0: Exclude
>-            - "Cover images will show for checked out items in the self checkout module for selected patron categories:"
>-
>         -
>             - "Include the following JavaScript on all pages in the web-based self checkout:"
>             - pref: SCOUserJS
>@@ -1291,6 +1284,11 @@ Circulation:
>             - pref: SelfCheckAllowByIPRanges
>               class: short
>             - (Leave blank if not used. Use ranges or simple IP addresses separated by spaces, like <code>192.168.1.1 192.168.0.0/24</code>.)
>+        -
>+            - "Cover images will show for checked out items in the self checkout module for selected patron categories:"
>+            - pref: SCOCoverImagesCategories
>+              choices: patron-categories
>+              class: multiple
>         -
>             - "Patron categories allowed to check out in a batch while logged into the self checkout system:"
>             - pref: SCOBatchCheckoutsValidCategories
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37463: 169807 | 169808 | 169809 | 169852 | 170492 | 170623 | 170686